fix(agent-core): write session metadata atomically#2162
Open
morluto wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 3e2948a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2159
Problem
Session metadata was overwritten in place. An interrupted write could leave a partial
state.json, and resume parsed that file before reconstructing any agents. The resulting raw JSON error made the session inaccessible even though its conversation records remained separate on disk.What changed
mv -fas the atomic fallback when the extension is unavailable. A failed replacement keeps the previous complete target.session.state_invalid.Validation:
pnpm --filter @moonshot-ai/kaos exec vitest run test/local.test.ts test/ssh.test.ts --reporter=dot— 120 passed, 17 skipped.pnpm --filter @moonshot-ai/agent-core exec vitest run test/session/init.test.ts test/session/store.test.ts test/harness/model-alias-session.test.ts --reporter=dot— 57 passed.pnpm --filter @moonshot-ai/kaos typecheckpnpm --filter @moonshot-ai/agent-core typecheckpnpm lint— zero errors.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.