fix(cli): preserve buffered prompt output during signal shutdown#2170
Open
morluto wants to merge 2 commits into
Open
fix(cli): preserve buffered prompt output during signal shutdown#2170morluto wants to merge 2 commits into
morluto wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 1fcd711 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbc128b682
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1897
Problem
Headless prompt output can be truncated when a signal arrives after the final assistant response and
session.resume_hinthave been queued but before a slow stdout pipe has flushed.The prompt runner removed its signal handlers at the start of asynchronous cleanup. A signal during permission restoration, telemetry shutdown, or harness disposal therefore used Node's default immediate exit. If the custom handler ran earlier, it also called
process.exit()without first draining stdout.This is especially damaging for
stream-json: consumers can lose both the final assistant message and the resume hint even though the completed response is already persisted.What changed
Writables before signal-triggered exit.PromptRunIOwriters that are not NodeWritables.Writable.The existing cleanup timeout, stdio-drain timeout, and force-exit fallback remain unchanged. A permanently stalled consumer is still bounded, and
SIGKILLremains outside the interceptable signal contract.Validation:
@moonshot-ai/kimi-codetypecheckgit diff --checkChecklist
gen-changesetsskill, and included a patch changeset.