fix(agent-core): recover sessions interrupted during thinking#2172
Open
morluto wants to merge 2 commits into
Open
fix(agent-core): recover sessions interrupted during thinking#2172morluto wants to merge 2 commits into
morluto wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: a5b526c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 946681c262
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1404
Related prior work: #1882
Problem
If a process exits after recording
step.beginand a nonempty thinking part but beforestep.end, v1 resume reconstructs the unfinished assistant step as ordinary history.The OpenAI-compatible adapter extracts the thinking part into
reasoning_content. Because the interrupted step has no answer text or tool call, the resulting request has neithercontentnortool_calls, and strict providers reject every later request from that session.The vacuous-message repair in #1968 handles empty or whitespace-only thinking. #1882 similarly checks assistant entries whose content array is empty. The record reported in #1404 contains a nonempty
ThinkPart, so it does not satisfy that predicate.What changed
contentnortool_calls.The adapter does not copy private reasoning into visible assistant content and does not rely on an empty-string fallback that strict providers may reject.
Validation:
@moonshot-ai/kosongand@moonshot-ai/agent-coretypechecksgit diff --checkChecklist
gen-changesetsskill, and included a patch changeset.