fix(vscode): recognize dark high-contrast themes#2180
Open
saime428 wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2158
Problem
The VS Code webview only treated
vscode-darkas a dark theme, so dark high-contrast themes rendered using the light UI theme.What changed
Treat
vscode-high-contrastas dark while explicitly keepingvscode-high-contrast-lightlight. VS Code adds the generic high-contrast class to light high-contrast themes for backward compatibility.Validation
pnpm -C apps/vscode run typecheckpnpm -C apps/vscode run build:webviewpnpm -C apps/vscode run test— 293 passed; 3 unrelated Windows path tests failedChecklist
gen-changesets; this private VS Code package change needs no changeset.