Skip to content

fix(vscode): recognize dark high-contrast themes#2180

Open
saime428 wants to merge 1 commit into
MoonshotAI:mainfrom
saime428:codex/fix-vscode-high-contrast-theme
Open

fix(vscode): recognize dark high-contrast themes#2180
saime428 wants to merge 1 commit into
MoonshotAI:mainfrom
saime428:codex/fix-vscode-high-contrast-theme

Conversation

@saime428

Copy link
Copy Markdown

Related Issue

Resolve #2158

Problem

The VS Code webview only treated vscode-dark as a dark theme, so dark high-contrast themes rendered using the light UI theme.

What changed

Treat vscode-high-contrast as dark while explicitly keeping vscode-high-contrast-light light. VS Code adds the generic high-contrast class to light high-contrast themes for backward compatibility.

Validation

  • pnpm -C apps/vscode run typecheck
  • pnpm -C apps/vscode run build:webview
  • Verified dark, dark high contrast, light, and light high contrast class combinations
  • pnpm -C apps/vscode run test — 293 passed; 3 unrelated Windows path tests failed

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue.
  • I have added tests that prove my feature works.
  • Ran gen-changesets; this private VS Code package change needs no changeset.
  • No documentation update is required.

@changeset-bot

changeset-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 43cb8a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS Code extension: webview renders in light theme under dark high-contrast color themes

1 participant