fix(test): remove shell-escaped newline from hooks runner test#2187
Open
panandicoding wants to merge 1 commit into
Open
fix(test): remove shell-escaped newline from hooks runner test#2187panandicoding wants to merge 1 commit into
panandicoding wants to merge 1 commit into
Conversation
The test appended a literal backslash-n via shell escaping which is misinterpreted on Windows (cmd.exe produces the two characters backslash+n instead of a newline). Since the assertion already uses .trim(), the trailing newline is unnecessary.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A (small test-only fix < 100 lines)
Description
The
externalHooksRunnertest "does not dedupe hooks that share a command but have different cwd" appends"\\n"toprocess.stdout.write(process.cwd())via shell escaping. On Windows, cmd.exe misinterprets the escaped sequence and outputs the literal two characters\ninstead of a newline, causing.trim()to fail to strip it and the assertion to fail.Since the assertion already applies
.trim()to the stdout, the trailing newline is unnecessary. Removing it makes the test pass on both Unix and Windows.Checklist