feat(tui): support mouse text selection in prompt editor#2202
feat(tui): support mouse text selection in prompt editor#2202FeiZhuLulu wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: ac60db7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac60db7e61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return { | ||
| row: Math.max(0, Math.min(layout.endRow - layout.startRow - 1, localRow)), | ||
| col: Math.max(1, Math.min(editorWidth - 2, localCol)), |
There was a problem hiding this comment.
When a prompt exceeds the editor's five-row-or-30% viewport, dragging above or below the editor clamps every event to the first or last currently rendered row. Because moving the selection head to that still-visible row never advances scrollOffset, there is no way to extend a mouse selection into the hidden lines; for example, a ten-line prompt initially showing lines 5–9 can never be dragged upward to select lines 0–4. Add edge-driven scrolling or map out-of-bounds drags to adjacent hidden rows.
Useful? React with 👍 / 👎.
| const start = Math.max(line.startCol, startCol); | ||
| const end = Math.min(line.endCol, endCol); | ||
| return end > start ? { start: start - line.startCol, end: end - line.startCol } : undefined; |
There was a problem hiding this comment.
When the selected range contains only a line break—such as dragging from the end of one line to column 0 of the next—or passes through an empty line, every affected visual line has end === start, so this returns no highlighted span. The editor still reports an active selection and Backspace or typing removes the newline, leaving users with an apparently unselected cursor that can unexpectedly join lines; render an end-of-line or empty-line cell for these ranges.
Useful? React with 👍 / 👎.
1 participant
Related Issue
Related to #1174
Problem
The prompt editor currently relies on keyboard navigation for cursor placement and text editing. Editing longer multi-line prompts is slow, while enabling terminal mouse reporting can interfere with native terminal selection unless the feature is explicitly gated and restores terminal state reliably.
What changed
Add experimental mouse text selection to the main prompt editor, enabled with
KIMI_CODE_EXPERIMENTAL_TERMINAL_MOUSE_INPUT=1.The editor now supports click-to-position, forward and reverse drag selection, wrapped and multi-line ranges, grapheme-safe deletion and replacement, atomic undo, and selected-text retrieval.
Ctrl+Ccopies an active selection while preserving the existing cancel/exit behavior when no selection exists.Kimi Code handles SGR mouse input only while the main editor is mounted, coalesces high-frequency drag events, maps coordinates from the latest rendered layout and actual viewport, and disables mouse reporting around dialogs, external editing, reloads, normal exit, and emergency terminal restoration. Holding
Shiftkeeps terminal-native selection and scrollback behavior available.English and Chinese documentation, package changesets, and regression coverage are included.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill is not present in this checkout.Verification
pnpm --filter @moonshot-ai/pi-tui typecheckpnpm --filter @moonshot-ai/pi-tui exec node --test test/editor.test.ts test/tui-render.test.ts— 254 passedpnpm --filter @moonshot-ai/kimi-code typecheckpnpm --filter @moonshot-ai/kimi-code exec vitest run test/tui/editor-mouse.test.ts test/tui/components/editor/custom-editor.test.ts test/tui/controllers/editor-keyboard.test.ts test/tui/commands/reload.test.ts test/tui/kimi-tui-startup.test.ts test/utils/terminal-restore.test.ts— 131 passedpnpm exec vitest run packages/node-sdk/test/config.test.ts— 12 passedpnpm --filter @moonshot-ai/pi-tui buildpnpm --filter @moonshot-ai/kimi-code buildpnpm exec changeset status --since=origin/maingit diff origin/main...HEAD --checkCtrl+C, lifecycle restoration, and coordinate stability after prompt shrinkage.