Added muon taggers to CRV KPP setup#1864
Conversation
|
Hi @ehrlich-uva,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for 059242e: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 059242e.
N.B. These results were obtained from a build of this Pull Request at 059242e after being merged into the base branch at 27e994d. For more information, please check the job page here. |
Issues found1. 2. Three large calibration files appear to be committed without a clear consumer / naming convention mismatch. The PR adds five
The PR body says "Still need to add new calibration tables to the DB" — so these committed text files are likely staging inputs for the DB upload, not consumed directly by Offline. Confirm whether all five need to live in the repo or whether some are throwaway generation inputs (the 3. -services.GeometryService.inputFile : "Offline/Mu2eG4/geom/geom_run1.txt"
+#services.GeometryService.inputFile : "Offline/Mu2eG4/geom/geom_run1.txt"
+services.GeometryService.inputFile : "Offline/Mu2eG4/geom/geom_common_extracted.txt"Confirm this default change is intended for committed test code (it changes what 4. This is the 1 TODO flagged by CI. Fine for KPP staging, but worth a tracking note so the support-structure geometry isn't forgotten. Possible improvements
|
|
📝 The HEAD of |
|
Updated SiPM and Time calibrations for the muon taggers for real data. |
Older files without muon taggers can still be processed after these changes.
The geometry of the CRV modules did not change.
Still need to add new calibration tables to the DB, since CRV channel number increased.