Skip to content

Added muon taggers to CRV KPP setup#1864

Merged
oksuzian merged 2 commits into
Mu2e:mainfrom
ehrlich-uva:CrvCalibration
Jul 2, 2026
Merged

Added muon taggers to CRV KPP setup#1864
oksuzian merged 2 commits into
Mu2e:mainfrom
ehrlich-uva:CrvCalibration

Conversation

@ehrlich-uva

@ehrlich-uva ehrlich-uva commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Older files without muon taggers can still be processed after these changes.
The geometry of the CRV modules did not change.
Still need to add new calibration tables to the DB, since CRV channel number increased.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @ehrlich-uva,
You have proposed changes to files in these packages:

  • CRVResponse
  • CRVReco
  • DataProducts
  • Mu2eG4
  • CRVConditions

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 059242e: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 059242e.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 059242e at 27e994d
build (prof) Log file. Build time: 08 min 36 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO ➡️ TODO (1) FIXME (0) in 3 files
clang-tidy ➡️ 2 errors 17 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 059242e after being merged into the base branch at 27e994d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian

Copy link
Copy Markdown
Collaborator

Issues found

1. clang-tidy reports 2 errors + 17 warnings — the CI table flags these but they don't block the build. Worth checking the clang-tidy log to confirm none come from the new CrvPhotonGenerator_module.cc edits.

2. Three large calibration files appear to be committed without a clear consumer / naming convention mismatch. The PR adds five *_extracted_*.txt data files but the fcl only bumps to v04/v05. Note the inconsistent date-vs-version naming:

  • calib_extracted_20260624.txt, status_extracted_20260624.txt (date-stamped)
  • calib_extracted_v04.txt, calib_extracted_v04_perfect.txt, extracted_v04.txt, photonyield_extracted_v04*.txt (version-stamped)

The PR body says "Still need to add new calibration tables to the DB" — so these committed text files are likely staging inputs for the DB upload, not consumed directly by Offline. Confirm whether all five need to live in the repo or whether some are throwaway generation inputs (the _perfect zero-deviation file especially).

3. printChannelMap.fcl switches the default geometry via commented-out line swap rather than cleanly. This leaves a dangling commented geom_run1.txt line:

-services.GeometryService.inputFile                   : "Offline/Mu2eG4/geom/geom_run1.txt"
+#services.GeometryService.inputFile                   : "Offline/Mu2eG4/geom/geom_run1.txt"
+services.GeometryService.inputFile                   : "Offline/Mu2eG4/geom/geom_common_extracted.txt"

Confirm this default change is intended for committed test code (it changes what printChannelMap operates on for everyone), or whether it should be reverted before merge.

4. nSupportStructures = 0 is explicitly a placeholder. In crv_counters_extracted_v04.txt:

int crs.nSupportStructures = 0;                                   //TODO: this is only a place holder so far

This is the 1 TODO flagged by CI. Fine for KPP staging, but worth a tracking note so the support-structure geometry isn't forgotten.

Possible improvements

  • epilog_extracted_v05.fcl: the 8 muon-tagger lookup tables all reuse LookupTable_2370_1 (the CRV-DS short module), with an inline comment acknowledging "no lookup table for 2200mm counters." Since M1–M8 are 2200 mm bars, consider a tracking issue to generate a proper 2200 mm table so the photon yield isn't approximated long-term.
  • DB dependency is a hard blocker for real use: per the PR body, reconstruction of new-format files will fail until the 2304-channel calibration tables are uploaded to the conditions DB. Recommend noting the DB PR/IOV here so reviewers know the merge order.
  • Scintillation-yield comment: the M1–M8 yields are set to 28610 ("assumed to be similar to CRV-L") — flag as an assumption to validate against measured tagger data when available.

@FNALbuild

Copy link
Copy Markdown
Collaborator

📝 The HEAD of main has changed to 4bda08c. Tests are now out of date.

@ehrlich-uva

Copy link
Copy Markdown
Contributor Author

Updated SiPM and Time calibrations for the muon taggers for real data.
The new geometry has more channels and requires the following database for MC:

services.DbService.purpose                           : Sim_best
services.DbService.version                           : v1_5

@ehrlich-uva ehrlich-uva marked this pull request as ready for review July 2, 2026 01:19
@oksuzian oksuzian merged commit 3d84f93 into Mu2e:main Jul 2, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants