Skip to content

fix: keep autocomplete from stealing focus#16

Draft
wengkit218-pixel wants to merge 2 commits into
Mudlet:masterfrom
wengkit218-pixel:codex/fix-autocomplete-focus-steal
Draft

fix: keep autocomplete from stealing focus#16
wengkit218-pixel wants to merge 2 commits into
Mudlet:masterfrom
wengkit218-pixel:codex/fix-autocomplete-focus-steal

Conversation

@wengkit218-pixel

Copy link
Copy Markdown

/claim #5310

This fixes autocomplete stealing focus from the editor, which prevented continued typing.

What changed:

  • Keep the autocomplete popup and list from taking focus.
  • Forward key presses back to the editor while autocomplete is visible.
  • Close autocomplete cleanly on Escape without forcing focus changes.
  • Add regression tests for typing, navigation keys, Escape, and sibling widget focus.

Validation:

  • cmake -S . -B build -G Ninja -DCMAKE_PREFIX_PATH=C:\msys64\ucrt64\lib\cmake -DBUILD_WITH_QT5=OFF
  • cmake --build build --target edbee-test -j 2
  • edbee-test.exe

Video demo:

@wengkit218-pixel

Copy link
Copy Markdown
Author

Hi! I submitted this PR 3 days ago to fix the autocomplete focus issue. Just checking if there's any update on the review? This is the upstream fix for Mudlet/Mudlet PR #9335. Let me know if I should make any changes. Thanks!

@wengkit218-pixel

Copy link
Copy Markdown
Author

Hi! I submitted this PR 7 days ago to fix the autocomplete focus stealing issue. Could you please review when you have a chance? Let me know if I should make any changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant