fix: use nanosecond experiment timestamps#563
Open
sudostock wants to merge 1 commit into
Open
Conversation
Reduce experiment directory collisions by using time_ns for generated and reset experiment IDs. Add focused coverage for both paths. Signed-off-by: Alex Filby <afilby@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce experiment directory collisions by using time_ns for generated experiment IDs.
We've run into a race condition a few times with DGXC benchmarks where users will try and launch multiple instance of the same experiment in parallel to overcome the slow nemo-run submit times. As the current timestamp is second based, and the folder is not created right after it's checked it's possible for:
This fix doesn't address the underlaying race condition, but should reduce the frequency and is also a necessary step if we can get nemo-run submissions to be sub-second.