fix: use title in Experiment.from_title not found message#564
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix: use title in Experiment.from_title not found message#564andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
Experiment.from_title previously referenced the built-in id() function in its assertion message, producing 'Experiment <built-in function id> not found.'. Update the message to use the title parameter and tighten the existing test to verify the message content. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug\n
Experiment.from_titlereferenced the built-inid()function in its assertion message, producingExperiment <built-in function id> not found.when the experiment directory was missing.\n\n## Fix\nUse thetitleparameter in the message instead.\n\n## Test\nUpdatedtest_from_title_nonexistentto assert that the error message contains the title.\n\n## Verification\nuv run pytest test/run/test_experiment.py::test_from_title_nonexistent -vpasses.\nuv run --group lint ruff check ...andruff format --check ...pass.