fix: avoid 'None' prefix in SlurmExecutor job names#565
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
SlurmExecutor.job_name_prefix defaults to None, so f-strings in alloc() and srun() produced job names like 'Noneinteractive'. Use so the prefix is omitted when unset, matching the existing handling in other methods. Adds regression tests for both alloc() and srun(). Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug\n
SlurmExecutor.job_name_prefixdefaults toNone, so thealloc()andsrun()f-strings produced job names likeNoneinteractive.\n\n## Fix\nUseself.job_name_prefix or ''in both methods, matching the existing handling elsewhere in the file (lines 825–830 and 980).\n\n## Test\nAddedtest/core/execution/test_slurm_job_name.pywith regression tests for bothalloc()andsrun(), covering the unset-prefix and set-prefix cases.\n\n## Verification\nuv run pytest test/core/execution/test_slurm_job_name.py -vpasses.\nuv run --group lint ruff check ...andruff format --check ...pass.