[https://nvbugs/6402500][fix] Only snapshot py_last_draft_tokens = py_draft_tokens for requests actually… - #15888
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughModifies ChangesDraft Token Fix and Test Waiver Removal
Estimated code review effort: 2 (Simple) | ~10 minutes Related PRs: None identified. Suggested labels: bug, disaggregated-serving Suggested reviewers: None identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
38e216a to
a35b7e9
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #57330 [ run ] triggered by Bot. Commit: |
|
PR_Github #57330 [ run ] completed with state
|
a35b7e9 to
d4f135a
Compare
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
d4f135a to
a1fcbf2
Compare
|
NVBug 6402500 is closed as Duplicate. The linked bug appears resolved elsewhere or for a reason that does not prove this PR is redundant. This PR should be judged on its own merits; repair-bot is not auto-closing it. |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
The diff is waiver-removal only — the _prepare_draft_requests gating this describes already landed in main via #16121 (filed under a different bug). Please retitle/reword to [chore] remove stale waivers and say the fix is already in, otherwise a future reader will look for a code change that isn't here.
Also: [waives.txt:252](https://github.com/NVIDIA/TensorRT-LLM/pull/15888/files#diff-621bd2af82a3b97c7a5948368d36c14582ffdf73361deb7f42d2ff395b22167eR252)-253 still waives the same two test_guided_decoding_with_eagle3[...eagle3_one_model=False] cases on H100 under nvbugs/6422334. If the same fix unblocked GB200, those look stale too — worth checking in the same pass.
Summary
_prepare_draft_requestsrecorded dummy draft tokens aspy_last_draft_tokensfor DISAGG_GENERATION_INIT requests, leaking stale state into the first draft invocation once transfer completed.py_last_draft_tokens = py_draft_tokensfor requests actually inGENERATION_IN_PROGRESS; leavepy_last_draft_tokensunchanged (None) while a request is still inDISAGG_GENERATION_INIT.Test plan
Links
Summary by CodeRabbit