-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[None][perf] fuse Kimi K3 routing and MXFP8 quantization #17059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
longlee0622
wants to merge
5
commits into
NVIDIA:main
Choose a base branch
from
longlee0622:agent/kimi-fused-route-quant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1775ca9
[None][perf] fuse Kimi route and MXFP8 quantization
longlee0622 4e906ef
[None][perf] enable Kimi fused route quant on SM10x
longlee0622 953f131
[None][test] cover prequantized Kimi route handoff
longlee0622 34c37e4
[None][fix] address Kimi route quant review feedback
longlee0622 c1bf03f
[None][fix] add Kimi MXFP8 handoff carrier
longlee0622 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is
MxFp8QuantizedTensordefined? The exact-headtensorrt_llm._torch.utilsexports onlyFp4QuantizedTensor, so this import fails before any MoE test can run. Please add the wrapper and handle its payload fields separately, or remove this incomplete handoff integration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. This PR used to target feat/kimi_k3 and I retargeted it to main since the k3 -> main merge back is almost done. It seems the
MxFp8QuantizedTensoris added to k3 feature branch in this PR but never merged back to main: https://github.com/NVIDIA/TensorRT-LLM/pull/17088/changes#diff-f2f9a3f5a11b927dc699020f15b174d43cb7fa6d3497a56dca733b8e7116960aR184@brnguyen2 Do you have any other merge-back PRs covering this part?