[https://nvbugs/6427411][test] Re-enable PP regression tests - #17117
Conversation
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated integration test waiver entries for disaggregated serving, model configurations, Ray, and LLM API cases. Added Llama3.3 FP4 skips and removed obsolete skips. ChangesIntegration waiver maintenance
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized test-configuration change re-enables the intended PP regression tests without changing production behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #63003 [ run ] triggered by Bot. Commit: |
BowenFu
left a comment
There was a problem hiding this comment.
Verified the premise rather than taking it on trust: #16163 is an exact line-for-line inverse of #15920's commit 4f1c3cd (179 changed lines each, the revert diff is the precise complement), nothing on main has re-introduced the host-side greedy-stop path, and main has exactly 30 6427411 lines — this removes all 30 and adds no new waiver. NVBugs 6427411 is already Bug - Fixed / Verify-to-Close with FixInfo pointing at #16163.
One non-blocking coverage note: 28 of the 30 are scheduled pre-merge (individually in l0_dgx_h100.yml / l0_dgx_b200.yml / l0_gb200_multi_gpus.yml, or via the -m "gpu2"/"gpu4" aggregates), so this PR's own /bot run re-exercises them. The two exceptions are post-merge only — TestNemotronV3Super::test_nvfp4_parallelism[TP4_PP2] (l0_dgx_b200.yml:247) and TestNemotronV3Ultra::test_nvfp4_parallelism[ADP2_PP2] (l0_gb200_multi_gpus.yml:85). The bug's own checklist asks for --extra-stage/--stage-list in exactly this case, so consider re-running with those two stages before merge.
FYI three of the removed entries also have a full:GB300/ or full:B300/ line under a different bug (6388153, 6322073); those are post-merge platform-scoped, so the tests correctly stay skipped there while returning to pre-merge.
|
PR_Github #63003 [ run ] completed with state |
01c40d9 to
a702ae9
Compare
Remove the remaining PP regression waivers added after NVIDIA#15920. The host-side greedy stop change was reverted by NVIDIA#16163, so these tests should run in CI again. Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot skip --comment 'unwaive test' |
|
PR_Github #66242 [ skip ] triggered by Bot. Commit: |
|
PR_Github #66242 [ skip ] completed with state |
|
/bot skip --comment 'unwaive test' |
|
PR_Github #66276 [ skip ] triggered by Bot. Commit: |
|
PR_Github #66276 [ skip ] completed with state |
Remove the remaining PP regression waivers added after #15920. The host-side greedy stop change was reverted by #16163, so these tests should run in CI again.
Dev Engineer Review
tests/integration/test_lists/waives.txtremoves obsolete waiver entries.QA Engineer Review
test-db/orqa/files were modified.tests/integration/test_lists/waives.txt.Verdict: needs follow-up
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.