Skip to content

[https://nvbugs/6517844][test] Unwaive DeepSeek V3 Lite RTX Pro 6000D test - #17364

Open
nv-lschneider wants to merge 3 commits into
NVIDIA:mainfrom
nv-lschneider:waive-deepseek-v3-lite-rtxpro6000d
Open

[https://nvbugs/6517844][test] Unwaive DeepSeek V3 Lite RTX Pro 6000D test#17364
nv-lschneider wants to merge 3 commits into
NVIDIA:mainfrom
nv-lschneider:waive-deepseek-v3-lite-rtxpro6000d

Conversation

@nv-lschneider

@nv-lschneider nv-lschneider commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

FIx merged with #16956
This just unwaives the test.

Dev Engineer Review

  • Removed the waiver for TestDeepSeekV3Lite::test_bfloat16_4gpus with ep4, CUDA graphs, overlap scheduling, and torch_compile=False.
  • The change removes the waiver linked to NVBugs issue 6517844.
  • The waiver file format and change scope are consistent.
  • No code, API, performance, or error-handling changes were made.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed one waiver entry.
  • No test-db/ or qa/ files were modified.
  • No test code changed.
  • CBTS coverage data is unavailable. Verdict: needs follow-up.
  • Please check this after reviewing the above items as appropriate for this PR.

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-*"

Signed-off-by: Ludwig Schneider <lschneider@nvidia.com>
@nv-lschneider
nv-lschneider force-pushed the waive-deepseek-v3-lite-rtxpro6000d branch from cdcd367 to 7f642ef Compare August 6, 2026 12:41
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fac4e9e4-a668-4ab5-8b31-17bd154b78c3

📥 Commits

Reviewing files that changed from the base of the PR and between 1fb6311 and b56205c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removes the waiver for the TestDeepSeekV3Lite::test_bfloat16_4gpus configuration with ep4, CUDA graphs, overlap scheduling, and torch_compile=False.

Changes

DeepSeek V3 Lite test waiver removal

Layer / File(s) Summary
Remove test waiver
tests/integration/test_lists/waives.txt
Removes the NVBugs-linked skip waiver for the DeepSeek V3 Lite BF16 four-GPU test configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b5620

This PR only removes the waiver for the DeepSeek V3 Lite RTX Pro 6000D test; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: qijune, tburt-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the purpose and related fix, but it omits the required Description and Test Coverage sections and does not document relevant tests. Add the required Description and Test Coverage sections, identify the related test or CI validation, and complete the applicable checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the NVBugs issue, test change, and primary action of removing the waiver.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64343 [ run ] triggered by Bot. Commit: 7f642ef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64343 [ run ] completed with state FAILURE. Commit: 7f642ef
/LLM/main/L0_MergeRequest_PR pipeline #52239 (Partly Tested) completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-*"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64356 [ run ] triggered by Bot. Commit: 7f642ef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64356 [ run ] completed with state SUCCESS. Commit: 7f642ef
/LLM/main/L0_MergeRequest_PR pipeline #52250 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the comments below are optional touch-ups, not blockers.

Matches the bug — the fix in #16956 landed and the bug asks for exactly this unwaive.

Two CI notes before merging:

  • The test only runs post-merge, so a plain /bot run won't cover it. Run /bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2" — it failed in both stages, not just -2.
  • The removed line has no GPU prefix, so it was skipping this parametrization on B200/B300/GB300 too (l0_dgx_b200.yml, l0_dgx_b300.yml, l0_gb300_multi_gpus.yml). Worth adding those multi-GPU post-merge stages as well so the re-enable doesn't turn into a post-merge surprise on a platform nobody checked.

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1,RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2,DGX_B300-4_GPUs-PyTorch-Post-Merge-1,DGX_B300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-3"

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

Thanks for the review, I am broadening the CI coverage to get full coverage.
Thanks for the detailed reply.

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1,RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2,DGX_B300-4_GPUs-PyTorch-Post-Merge-1,DGX_B300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-3"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64612 [ run ] triggered by Bot. Commit: 7f642ef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64612 [ run ] completed with state SUCCESS. Commit: 7f642ef
/LLM/main/L0_MergeRequest_PR pipeline #52471 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1,RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2,DGX_B300-4_GPUs-PyTorch-Post-Merge-1,DGX_B300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-3"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64687 [ run ] triggered by Bot. Commit: 7f642ef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64687 [ run ] completed with state SUCCESS. Commit: 7f642ef
/LLM/main/L0_MergeRequest_PR pipeline #52543 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run

Signed-off-by: Ludwig Schneider <lschneider@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Signed-off-by: Ludwig Schneider <lschneider@nvidia.com>
@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1,RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2,DGX_B300-4_GPUs-PyTorch-Post-Merge-1,DGX_B300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-3"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66301 [ run ] triggered by Bot. Commit: b56205c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66301 [ run ] completed with state FAILURE. Commit: b56205c

Link to invocation

@nv-lschneider

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1,RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2,DGX_B300-4_GPUs-PyTorch-Post-Merge-1,DGX_B300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-3"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66389 [ run ] triggered by Bot. Commit: b56205c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66389 [ run ] completed with state FAILURE. Commit: b56205c
/LLM/main/L0_MergeRequest_PR pipeline #54033 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants