[https://nvbugs/6566786][test] Unwaive fixed DeepSeek tests - #17471
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe change removes obsolete skipped-test waivers and updates the B300 waiver subset in the integration waiver list. It retains the specified existing entries and the MiniMax MXFP8 waiver. ChangesTest waiver cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --stage-list "DGX_B200-8_GPUs-PyTorch-1, GB300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #65018 [ run ] triggered by Bot. Commit: |
|
PR_Github #65018 [ run ] completed with state
|
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Two waivers removed, but the description only justifies one of them. The TestDeepSeekV32::test_nvfp4_multi_gpus_piecewise_cuda_graph[mtp3_fp8kv_chunked] line is tagged https://nvbugs/5989920, not 6566786, and its failure signature is unrelated to what #16952 changed. Please state in the description what fixed 5989920 (it looks separately resolved), or drop that line from this PR.
Also: both tests run in post-merge stages, so a default /bot run won't exercise either removal. Trigger the specific stages with /bot run --extra-stage "..." and link the passing run before merging.
|
/bot run --stage-list "DGX_B200-8_GPUs-PyTorch-1, GB300-4_GPUs-PyTorch-Post-Merge-2" |
|
/bot run --stage-list "DGX_B200-8_GPUs-PyTorch-1, GB300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #65262 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "DGX_B200-8_GPUs-PyTorch-3, GB300-4_GPUs-PyTorch-Post-Merge-3" |
|
PR_Github #65282 [ run ] triggered by Bot. Commit: |
|
PR_Github #65262 [ run ] completed with state |
|
PR_Github #65282 [ run ] completed with state
|
|
/bot run --stage-list "DGX_B200-8_GPUs-PyTorch-3, GB300-4_GPUs-PyTorch-Post-Merge-3" |
|
PR_Github #65285 [ run ] triggered by Bot. Commit: |
Fixed by NVIDIA#16952 Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
92a5df7 to
c84bd3d
Compare
|
/bot run --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1, GB300-4_GPUs-PyTorch-Post-Merge-2, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-PyTorch-4, DGX_B200-PyTorch-5, DGX_B200-PyTorch-6, DGX_H100-4_GPUs-PyTorch-Others-2" |
|
PR_Github #65293 [ run ] triggered by Bot. Commit: |
|
PR_Github #65285 [ run ] completed with state |
|
PR_Github #65293 [ run ] completed with state
|
|
/bot run --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1, GB300-4_GPUs-PyTorch-Post-Merge-2, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-PyTorch-4, DGX_B200-PyTorch-5, DGX_B200-PyTorch-6, DGX_H100-4_GPUs-PyTorch-Others-2" |
|
PR_Github #65468 [ run ] triggered by Bot. Commit: |
|
PR_Github #65468 [ run ] completed with state
|
|
/bot run --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1, GB300-4_GPUs-PyTorch-Post-Merge-2, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-PyTorch-4, DGX_B200-PyTorch-5, DGX_B200-PyTorch-6, DGX_H100-4_GPUs-PyTorch-Others-2" |
|
PR_Github #65838 [ run ] triggered by Bot. Commit: |
|
PR_Github #65838 [ run ] completed with state
|
|
/bot run |
|
PR_Github #66133 [ run ] triggered by Bot. Commit: |
|
PR_Github #66133 [ run ] completed with state |
Fixed by #16952
Dev Engineer Review
QA Engineer Review
test-db/orqa/files were modified.tests/integration/test_lists/waives.txt.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.