Skip to content

[https://nvbugs/6577550][chore] Waive TestNemotron3Super120B::test_ctx_dp2_gen_tp4 - #17504

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
yihwang-nv:user/yihwang/waive-nemotron3super-ctx-dp2
Aug 11, 2026
Merged

[https://nvbugs/6577550][chore] Waive TestNemotron3Super120B::test_ctx_dp2_gen_tp4#17504
2ez4bz merged 1 commit into
NVIDIA:mainfrom
yihwang-nv:user/yihwang/waive-nemotron3super-ctx-dp2

Conversation

@yihwang-nv

@yihwang-nv yihwang-nv commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Description

accuracy/test_disaggregated_serving.py::TestNemotron3Super120B::test_ctx_dp2_gen_tp4 is currently waived only under the full:B300/ GPU prefix (nvbugs/6577550). The underlying GSM8K accuracy regression is not B300-specific:

Bug GPU Evaluated accuracy (threshold 89.497) Status
6546605 B200 @ d924d9f1 64.594 Closed, "fixed" by #16072
6577550 B300 @ f0dc88f2 26.876 Open, P0

Same test, same failure signature, both categorized Module_Disaggregated serving and marked as regressions. The failure originally surfaced on B200; it was declared fixed by #16072 and has since resurfaced on B300 at an even lower score, so #16072 appears to have masked rather than fixed it. The test has now been observed failing on B200 again.

This PR widens the waive from the full:B300/ prefix to an unprefixed entry so every stage is covered.

Note that simply adding a full:B200/ line would not have been sufficient: parse_test_name in tests/integration/defs/test_list_parser.py only substitutes the stage's test prefix when test_prefix.split('-')[0] appears in the line, so full:B200/ matches B200-* stages but not the DGX_B200-* stages where this test also runs (l0_dgx_b200.yml).

Only test_ctx_dp2_gen_tp4 is affected. The sibling test_auto_dtype parametrizations keep their existing, separately tracked waives.

Test Coverage

Test-list-only change; no product code is touched. The waives.txt duplicate check and the test-list-entry AST validation pre-commit hooks both pass.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

🤖 Generated with Claude Code

Dev Engineer Review

  • Updated tests/integration/test_lists/waives.txt.
  • Replaced the full:B300/ waiver with an unprefixed waiver for test_ctx_dp2_gen_tp4.
  • The wider waiver covers both B200 and B300 stages, including DGX_B200-*.
  • Sibling test_auto_dtype waivers remain unchanged.
  • Waiver duplicate checks and test-list AST validation pass.
  • No product code or public API changes exist.

Verdict: sufficient

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed the B300-specific waiver entry.
  • Added the unprefixed waiver entry for accuracy/test_disaggregated_serving.py::TestNemotron3Super120B::test_ctx_dp2_gen_tp4.
  • No test-db/ or qa/ files changed.
  • The waiver targets an existing test and has the required broader stage coverage.

Verdict: needs follow-up because CBTS coverage data is unavailable.

…x_dp2_gen_tp4

The GSM8K accuracy regression tracked by nvbugs/6577550 is not specific to
B300. The same test with the same signature first failed on B200 under
nvbugs/6546605 (64.594 vs. a 89.497 threshold), was closed as fixed by NVIDIA#16072,
and has since resurfaced at 26.876 on B300. Widen the waive from the B300 GPU
prefix to all stages so B200 and DGX_B200 are covered too -- note that
`full:B200/` would not have matched the `DGX_B200-*` stages anyway, since
parse_test_name only substitutes a test prefix that appears in the line.

Signed-off-by: Yihan Wang <yihwang@nvidia.com>
@yihwang-nv

Copy link
Copy Markdown
Collaborator Author

/bot --help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label. Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers). Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers).

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline. Requires the ci: post-merge approved PR label applied by an active member of NVIDIA/trt-llm-ci-approvers. The approval label remains in place when new commits are pushed.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label.

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The standard accuracy waiver list adds a skip for the Nemotron3 Super 120B context/data-parallel test.

Changes

Nemotron3 test waiver

Layer / File(s) Summary
Update Nemotron3 test waiver
tests/integration/test_lists/waives.txt
The standard accuracy test list skips TestNemotron3Super120B::test_ctx_dp2_gen_tp4.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bowenfu, brnguyen2, stanleysun639

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required NVBugs and type format and clearly identifies the waived test.
Description check ✅ Passed The description explains the issue, solution, affected test, scope, and test coverage, and includes the required checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 16: Add the repository-standard NVIDIA copyright header, including 2026,
at the top of the waiver-list file while preserving the existing waiver entry
and parser-compatible format.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1c6baf6f-a133-44ba-832d-eebdecd90f78

📥 Commits

Reviewing files that changed from the base of the PR and between 6b05285 and d85db37.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@yihwang-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Just waived 1 test"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65315 [ skip ] triggered by Bot. Commit: d85db37 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65315 [ skip ] completed with state SUCCESS. Commit: d85db37
Skipping testing for commit d85db37

Link to invocation

@2ez4bz
2ez4bz enabled auto-merge (squash) August 11, 2026 15:59
@2ez4bz
2ez4bz merged commit 4ffb1b2 into NVIDIA:main Aug 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants