Skip to content

[None][test] Waive test_kda_verify_matches_sequential_decode[2-1] (NaN on B200) - #17561

Merged
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:user/brnguyen/waive-kimi-kda-verify-parity
Aug 12, 2026
Merged

[None][test] Waive test_kda_verify_matches_sequential_decode[2-1] (NaN on B200)#17561
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:user/brnguyen/waive-kimi-kda-verify-parity

Conversation

@brnguyen2

@brnguyen2 brnguyen2 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Waives unittest/_torch/modeling/test_kimi_kda_verify_parity.py::test_kda_verify_matches_sequential_decode[2-1], which fails with NaN on DGX B200 (100% mismatched elements, greatest abs difference = nan). Observed in the L0 MergeRequest PR pipeline (build 53227, DGX_B200-PyTorch-4 stage).

The [2-1] case (t_steps=2, batch=1) of the KDA speculative-verify parity check produces NaN output from the verify path. Tracking bug: https://nvbugs/6599150.

This is a waive-only change to unblock CI; the underlying KDA verify NaN is tracked separately.

Dev Engineer Review

  • Added one waiver for test_kda_verify_matches_sequential_decode[2-1].
  • Referenced bug 6599150.
  • The waiver format and scope are consistent with the test-list file.
  • The change only unblocks CI. It does not modify test behavior or public APIs.
  • No duplicate waiver or configuration issue was identified.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Added one waiver entry for the Kimi KDA verification parity test.
  • No test-db or QA entries were modified.
  • CBTS coverage data is unavailable. Verdict: needs follow-up.

…N on B200)

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
@brnguyen2
brnguyen2 force-pushed the user/brnguyen/waive-kimi-kda-verify-parity branch from da78d58 to d7b44eb Compare August 12, 2026 15:41
@brnguyen2
brnguyen2 marked this pull request as ready for review August 12, 2026 15:42
@brnguyen2
brnguyen2 enabled auto-merge (squash) August 12, 2026 15:43
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2ad0e56c-2944-4b37-ba2e-11fd7ef57f51

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6a8cb and d7b44eb.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The integration test waiver list now skips test_kda_verify_matches_sequential_decode[2-1] and references NVBugs issue 6599150.

Changes

KDA verification waiver

Layer / File(s) Summary
Add KDA parity test skip entry
tests/integration/test_lists/waives.txt
Adds a skip marker for the KDA verification parity test with NVBugs reference 6599150.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: bowenfu, qijune

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly identifies the waived KDA parity test and its NaN failure on B200.
Description check ✅ Passed The description explains the failure, affected test, observed environment, tracking bug, and waiver purpose; the missing template headings are non-critical here.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65602 [ run ] triggered by Bot. Commit: d7b44eb Link to invocation

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive-only PR"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65603 [ skip ] triggered by Bot. Commit: d7b44eb Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65602 [ run ] completed with state ABORTED. Commit: d7b44eb

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65603 [ skip ] completed with state SUCCESS. Commit: d7b44eb
Skipping testing for commit d7b44eb

Link to invocation

@brnguyen2
brnguyen2 merged commit 3a3cbe7 into NVIDIA:main Aug 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants