[None][chore] Unwaive flaky accuracy tests - #17623
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe change removes two skipped integration-test entries from ChangesIntegration test waiver cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only re-enables two previously waived accuracy tests so their current behavior is visible in CI; it introduces no runtime code change, and no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #65836 [ run ] triggered by Bot. Commit: |
|
PR_Github #65836 Bot args parsing error: CI requested by |
|
Removed the "ci: post-merge approved" label because @bobboli could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #65842 [ run ] triggered by Bot. Commit: |
|
PR_Github #65842 Bot args parsing error: CI requested by |
|
/bot run --disable-fail-fast --post-merge |
|
PR_Github #65880 [ run ] triggered by Bot. Commit: |
|
PR_Github #65880 [ run ] completed with state
|
|
/bot run --disable-fail-fast --post-merge --reuse-test |
|
PR_Github #65969 [ run ] triggered by Bot. Commit: |
|
PR_Github #65969 [ run ] completed with state
|
|
/bot run --disable-fail-fast --post-merge --reuse-test |
|
PR_Github #66161 [ run ] triggered by Bot. Commit: |
|
PR_Github #66161 [ run ] completed with state
|
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
359cb30 to
8be625b
Compare
|
/bot run --disable-fail-fast --post-merge --reuse-test |
|
PR_Github #66219 [ run ] triggered by Bot. Commit: |
|
PR_Github #66219 [ run ] completed with state
|
Description
Remove the waivers for two flaky accuracy tests associated with NVBugs 6458213, 6523809, and 6530221:
This PR intentionally contains no runtime code change or claimed fix. It re-enables the tests so current failures can be observed and diagnosed in CI.
Test Coverage
The unwaived tests are:
Pre-commit hooks passed, including test-list validation. GPU coverage is delegated to CI on the applicable H100, B200, and GB200 stages.
PR Checklist
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.