Skip to content

[None][chore] Extend OpenEngine ownership to dynamo dev - #17657

Open
tanmayv25 wants to merge 3 commits into
NVIDIA:mainfrom
tanmayv25:chore/add-grpc-server-codeowner
Open

[None][chore] Extend OpenEngine ownership to dynamo dev#17657
tanmayv25 wants to merge 3 commits into
NVIDIA:mainfrom
tanmayv25:chore/add-grpc-server-codeowner

Conversation

@tanmayv25

@tanmayv25 tanmayv25 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Add @NVIDIA/trt-llm-dynamo-devs as a co-owner with @NVIDIA/trt-llm-runtime-devs for the OpenEngine gRPC adapter under tensorrt_llm/grpc/openengine.
  • Add the same ownership for its unit tests under tests/unittest/grpc/openengine.
  • Keep shared gRPC, LLMAPI, CLI, packaging, and dependency files under their existing ownership rules.

This reflects the maintenance boundary described in #17016: the OpenEngine contributor community owns the adapter implementation, tests, protocol updates, and related fixes, while the TensorRT-LLM runtime team retains integration oversight. It also supports timely review of the implementation series beginning with #17084.

Impact

Future changes scoped to the OpenEngine adapter or its unit tests can request review from @NVIDIA/trt-llm-dynamo-devs.

Validation

  • git diff --check
  • pre-commit run --files .github/CODEOWNERS

PR Checklist

  • The CODEOWNERS entries are narrowly scoped and preserve existing runtime-team co-ownership.
  • The commit includes a DCO sign-off.

Dev Engineer Review

  • Added @NVIDIA/trt-llm-dynamo-devs as a co-owner for:
    • /tensorrt_llm/grpc/openengine
    • /tests/unittest/grpc/openengine
  • Preserved ownership by @NVIDIA/trt-llm-runtime-devs.
  • Limited the CODEOWNERS scope to the OpenEngine adapter and its unit tests.
  • No code, API, performance, or error-handling changes.
  • Validation includes git diff --check and pre-commit checks.

QA Engineer Review

  • No test files changed.
  • The CODEOWNERS update does not require CI or manual QA coverage changes.

Signed-off-by: tanmayv25 <tanmay2592@gmail.com>
@tanmayv25
tanmayv25 marked this pull request as ready for review August 13, 2026 20:14
@tanmayv25
tanmayv25 requested review from a team as code owners August 13, 2026 20:14
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a73017b7-873c-4239-8226-ae30b286b0f0

📥 Commits

Reviewing files that changed from the base of the PR and between fd913be and ca152ca.

📒 Files selected for processing (1)
  • .github/CODEOWNERS
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/CODEOWNERS

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


Walkthrough

The CODEOWNERS file assigns runtime and Dynamo ownership to the OpenEngine implementation path and its unit test path.

Changes

OpenEngine ownership

Layer / File(s) Summary
Add OpenEngine ownership entries
.github/CODEOWNERS
Adds runtime and Dynamo ownership for the OpenEngine implementation and unit test paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ca152

This narrowly scoped ownership update does not change product behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dpitman-nvda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: extending OpenEngine ownership to the Dynamo development team.
Description check ✅ Passed The description explains the ownership changes, scope, impact, validation steps, and checklist items with sufficient detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Comment thread .github/CODEOWNERS Outdated
Signed-off-by: tanmayv25 <tanmay2592@gmail.com>
@tanmayv25 tanmayv25 changed the title chore(codeowners): add OpenEngine ownership [None][chore] Extend OpenEngine ownership to dynamo dev Aug 14, 2026
@tanmayv25
tanmayv25 enabled auto-merge (squash) August 14, 2026 17:40
@mikeiovine

Copy link
Copy Markdown
Collaborator

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66830 [ run ] triggered by Bot. Commit: a7994b5 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66830 [ run ] completed with state SUCCESS. Commit: a7994b5
/LLM/main/L0_MergeRequest_PR pipeline #54392 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@tanmayv25

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66851 [ run ] triggered by Bot. Commit: ca152ca Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants