[None][chore] Extend OpenEngine ownership to dynamo dev - #17657
[None][chore] Extend OpenEngine ownership to dynamo dev#17657tanmayv25 wants to merge 3 commits into
Conversation
Signed-off-by: tanmayv25 <tanmay2592@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. WalkthroughThe CODEOWNERS file assigns runtime and Dynamo ownership to the OpenEngine implementation path and its unit test path. ChangesOpenEngine ownership
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This narrowly scoped ownership update does not change product behavior, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: tanmayv25 <tanmay2592@gmail.com>
|
/bot run |
|
PR_Github #66830 [ run ] triggered by Bot. Commit: |
|
PR_Github #66830 [ run ] completed with state
|
|
/bot run |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
PR_Github #66851 [ run ] triggered by Bot. Commit: |
Description
@NVIDIA/trt-llm-dynamo-devsas a co-owner with@NVIDIA/trt-llm-runtime-devsfor the OpenEngine gRPC adapter undertensorrt_llm/grpc/openengine.tests/unittest/grpc/openengine.This reflects the maintenance boundary described in #17016: the OpenEngine contributor community owns the adapter implementation, tests, protocol updates, and related fixes, while the TensorRT-LLM runtime team retains integration oversight. It also supports timely review of the implementation series beginning with #17084.
Impact
Future changes scoped to the OpenEngine adapter or its unit tests can request review from
@NVIDIA/trt-llm-dynamo-devs.Validation
git diff --checkpre-commit run --files .github/CODEOWNERSPR Checklist
Dev Engineer Review
@NVIDIA/trt-llm-dynamo-devsas a co-owner for:/tensorrt_llm/grpc/openengine/tests/unittest/grpc/openengine@NVIDIA/trt-llm-runtime-devs.git diff --checkand pre-commit checks.QA Engineer Review