[TRTLLM-15102][fix] Prune VILA family models - #17675
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR removes VILA and NVILA multimodal accuracy tests, unit-test configuration, accuracy references, a fixture override, and a pre-merge test entry. ChangesVILA and NVILA coverage cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes out-of-scope VILA-family test coverage and related test references without indicating a product or runtime behavior change. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "l40s" |
|
PR_Github #66168 [ run ] triggered by Bot. Commit: |
|
PR_Github #66168 [ run ] completed with state
|
|
/bot run --stage-list "L40S-*" |
1 similar comment
|
/bot run --stage-list "L40S-*" |
|
PR_Github #66224 [ run ] triggered by Bot. Commit: |
pengbowang-nv
left a comment
There was a problem hiding this comment.
Attention part change LGTM
|
PR_Github #66224 [ run ] completed with state |
…nctional and unit tests Remove out-of-scope VILA, VILA1.5-3b, and NVILA-8B coverage per Test Scope Review 2026.7, matching the LLaVA-Next prune pattern. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot reuse-pipeline |
|
PR_Github #66285 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #66285 [ reuse-pipeline ] completed with state |
…nctional and unit tests
Remove out-of-scope VILA, VILA1.5-3b, and NVILA-8B coverage per Test Scope Review 2026.7, matching the LLaVA-Next prune pattern.
Dev Engineer Review
QA Engineer Review
TestNVILA_8BTestVILA1_5_3Btests/unittest/_torch/modeling/test_modeling_vila.py, including VILA model tests and multimodal token-alignment tests.tests/integration/test_lists/qa/llm_function_core.txttests/integration/test_lists/qa/llm_function_rtx6k.txttests/integration/test_lists/test-db/l0_l40s.ymltests/integration/test_lists/waives.txtDescription
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.