Skip to content

[https://nvbugs/6507082][fix] remove a test case of falcon model - #17677

Merged
QiJune merged 1 commit into
NVIDIA:mainfrom
QiJune:fix_6507082
Aug 14, 2026
Merged

[https://nvbugs/6507082][fix] remove a test case of falcon model#17677
QiJune merged 1 commit into
NVIDIA:mainfrom
QiJune:fix_6507082

Conversation

@QiJune

@QiJune QiJune commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the Falcon-7B-Instruct incremental tokenizer decoding test case.
  • Removed its two matching entries from tests/integration/test_lists/waives.txt.
  • The changes are consistent and limited to NVBugs issue 6507082.
  • No API, performance, or error-handling changes were introduced.

QA Engineer Review

  • Removed the Falcon-7B-Instruct case from the incremental tokenizer decoding parametrization in tests/unittest/llmapi/test_llm.py.
  • Removed two corresponding tokenizer_decode_incrementally entries from tests/integration/test_lists/waives.txt.
  • No test-db/ or qa/ coverage updates were provided.
  • Verdict: needs follow-up.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune

QiJune commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0d1b12ce-ea1a-403c-8958-33021af98a89

📥 Commits

Reviewing files that changed from the base of the PR and between b51abef and 6d23aa1.

📒 Files selected for processing (2)
  • tests/integration/test_lists/waives.txt
  • tests/unittest/llmapi/test_llm.py
💤 Files with no reviewable changes (2)
  • tests/integration/test_lists/waives.txt
  • tests/unittest/llmapi/test_llm.py

Walkthrough

The PR removes the Falcon-7B-Instruct case from incremental tokenizer decoding tests and removes its two corresponding entries from the waiver list.

Changes

Tokenizer test cleanup

Layer / File(s) Summary
Remove Falcon tokenizer cases
tests/unittest/llmapi/test_llm.py, tests/integration/test_lists/waives.txt
The incremental tokenizer test no longer parametrizes the Falcon-7B-Instruct model. The waiver list no longer contains its skipped entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6d23a

This is a localized test cleanup that removes a Falcon test case and its waiver entries; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Suggested reviewers: schetlur-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains the template but does not explain the issue, solution, or test coverage. Add a brief issue and solution summary, list relevant test coverage, and complete the checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Falcon test-case removal and references the related NVBugs issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66205 [ run ] triggered by Bot. Commit: 6d23aa1 Link to invocation

@QiJune
QiJune enabled auto-merge (squash) August 14, 2026 07:30
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66205 [ run ] completed with state SUCCESS. Commit: 6d23aa1
/LLM/main/L0_MergeRequest_PR pipeline #53874 completed with status: 'SUCCESS'

CI Report

Link to invocation

@QiJune
QiJune merged commit 807c4f6 into NVIDIA:main Aug 14, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants