Prevent OOB write for RBK and RLE in streaming context - #10504
Open
nanan-nvidia wants to merge 1 commit into
Open
Prevent OOB write for RBK and RLE in streaming context#10504nanan-nvidia wants to merge 1 commit into
nanan-nvidia wants to merge 1 commit into
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesStreaming unique-count handling
Assessment against linked issues
Suggested reviewers: Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cub/cub/device/dispatch/dispatch_reduce_by_key.cuh (1)
105-109: 🩺 Stability & Availability | 🔵 Trivial | 🏗️ Heavy liftsuggestion: Add focused regression coverage for both streaming implementations using 64-bit
num_items, a single partition, and an unaligned temporary-storage base, then run Compute Sanitizer. Ordinary output assertions may pass even if the zero-sized auxiliary buffer is still written.
cub/cub/device/dispatch/dispatch_reduce_by_key.cuh#L105-L109: validate reduce-by-key output and sanitizer cleanliness.cub/cub/device/dispatch/dispatch_rle.cuh#L101-L105: validate RLE output and sanitizer cleanliness.
This follows the PR objective of preventing silent out-of-bounds writes in these exact streaming paths.Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a5a1bc55-8617-4574-86aa-b32b3b2ca933
📒 Files selected for processing (2)
cub/cub/device/dispatch/dispatch_reduce_by_key.cuhcub/cub/device/dispatch/dispatch_rle.cuh
Jacobfaib
approved these changes
Jul 27, 2026
miscco
approved these changes
Jul 28, 2026
elstehle
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10036