Skip to content

fix: _create_driver_package never builds nvidia-uvm.ko #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: _create_driver_package never builds nvidia-uvm.ko #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rhel9/nvidia-driver
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ _create_driver_package() (
fi
fi

make -s -j ${MAX_THREADS} SYSSRC=/lib/modules/${KERNEL_VERSION}/build nv-linux.o nv-modeset-linux.o > /dev/null
make -s -j ${MAX_THREADS} SYSSRC=/lib/modules/${KERNEL_VERSION}/build nv-linux.o nv-modeset-linux.o nvidia-uvm.ko > /dev/null

echo "Relinking NVIDIA driver kernel modules..."
rm -f nvidia.ko nvidia-modeset.ko
Expand Down
17 changes: 17 additions & 0 deletions test_create_driver_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/bin/bash
set -euo pipefail

# Regression test: the _create_driver_package function must list nvidia-uvm.ko
# as a make target because it is signed and packed later in the same function.
func_body=$(sed -n '/^_create_driver_package()/,/^}/p' rhel9/nvidia-driver)
make_line=$(printf '%s\n' "$func_body" | grep -E '^\s+make -s -j .* SYSSRC=')

if [ -z "$make_line" ]; then
echo "FAIL: could not find the make invocation in _create_driver_package"
exit 1
fi

if printf '%s\n' "$make_line" | grep -q 'nvidia-uvm.ko'; then
echo "PASS: _create_driver_package builds nvidia-uvm.ko"
else
echo "FAIL: _create_driver_package does not build nvidia-uvm.ko"