feat(helm): deploy BMC proxy as part of NICo Core by default#3682
Open
shayan1995 wants to merge 1 commit into
Open
feat(helm): deploy BMC proxy as part of NICo Core by default#3682shayan1995 wants to merge 1 commit into
shayan1995 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
Summary by CodeRabbit
WalkthroughThe Helm chart now enables the BMC proxy by default as part of NICo Core, documents its DPS-based provisioning role, and adds a template test verifying the rendered Deployment and Core image. ChangesBMC Proxy Core Integration
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
nvaprado
approved these changes
Jul 17, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm/README.md`:
- Around line 127-128: The Helm README example must qualify the BMC proxy
requirement with the external-proxy exception. Update the nico-bmc-proxy
documentation near its enabled setting to state that disabling it is supported
only when an external BMC Proxy is deployed and wired separately, while
preserving the existing DPS-based provisioning context.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f7da862f-39e2-4ad4-878b-ccac078d8893
📒 Files selected for processing (1)
helm/README.md
BMC Proxy is required for DPS-based power provisioning, so it shall always be deployed as part of NICo Core (NVIDIA#3298). Flip the umbrella chart default for nico-bmc-proxy to enabled and document when it can be turned off (only when an external BMC proxy is deployed and wired separately). The subchart already ships with safe defaults for a default-on component: the ServiceMonitor and the external LoadBalancer Service remain opt-in, and its certificate/vault/database dependencies are the standard NICo Core prerequisites. Also list nico-bmc-proxy in the README subchart enable/disable example (it was missing entirely), including the external-proxy exception, and note in the component table that it is required for DPS-based power provisioning. Adds a chart test asserting the BMC proxy Deployment renders by default into the release namespace using the shared Core image. Fixes NVIDIA#3298 Signed-off-by: Shayan Namaghi <snamaghi@nvidia.com>
shayan1995
force-pushed
the
snamaghi/issue-3298-enable-bmc-proxy
branch
from
July 17, 2026 20:51
c89382b to
28ddbf1
Compare
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BMC Proxy is required for DPS-based power provisioning, so it shall always be deployed as part of NICo Core (#3298). This flips the umbrella chart default for
nico-bmc-proxyto enabled and documents when it can be turned off (only when an external BMC proxy is deployed and wired separately).The subchart already ships with safe defaults for a default-on component: the ServiceMonitor and the external LoadBalancer Service remain opt-in, and its certificate/vault/database dependencies are the standard NICo Core prerequisites.
Adds a chart test asserting the BMC proxy Deployment renders by default into the release namespace using the shared Core image.
Related issues
Fixes #3298
Type of Change
Breaking Changes
Testing
helm unittestpasses for the new suite; the full chart test run shows no new failures relative to main.