Add nvbench-compare-robust --plot-output/--plot-along-output options - #433
Open
oleksandr-pavlyk wants to merge 6 commits into
Open
Conversation
The intent is to allow producing plotting artifacts in headless environments. Closes NVIDIA#395
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe PR adds explicit output paths for summary and Plot output handling
Assessment against linked issues
Comment |
oleksandr-pavlyk
marked this pull request as draft
July 23, 2026 18:51
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
oleksandr-pavlyk
marked this pull request as ready for review
July 24, 2026 13:40
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…related data Introduced _nvbench_compare_plotting.py helper that contains class PlotCollector. PlotCollector owns plotting-related state and rendering, and compare_benches() interacts with plotting through that collector. compare_benches() still produces comparison facts, but delegates plotting state management and rendering to PlotCollector.
oleksandr-pavlyk
force-pushed
the
add-explicit-plot-output-options-in-compare-script
branch
from
July 24, 2026 17:52
06becf1 to
e37d351
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to allow producing plotting artifacts in headless environments without relying on Linux-centric
"DISPLAY"environment variable and allowing user to select matplotlib's backend via environment variables.--plot-output PATHfor summary plots (i.e.,--plotwas specified).--plot-along-output PATH_OR_TEMPLATEfor--plot-along.plt.show().fig.savefig(..., dpi=150)and skipplt.show().--plot-along-outputsupports{benchmark},{device},{axis},{pair}templates.In addition, plotting data and their manipulation have been decoupled from
compare_benchesare now performed usingPlotCollectorclass. All plotting-related functionality has been move to helper source file_nvbench_compare_plotting.pyresiding next tonvbench_compare_robust.py.Closes #395