#4215 Add work package factory and process#4304
Conversation
|
Dependency added: ora (an elegant terminal spinner for a cleaner and modern look for the seed generation). |
Steph375
left a comment
Steph375
left a comment
There was a problem hiding this comment.
Looks good just a few things! Also not sure if I'm missing something but I see the project template configs include workPackageTemplates, but I don’t see those being created/connected in projectTemplateCreateInput. Are those work package templates created somewhere else that I missed, or should that be added there?
| "@types/multer": "^1.4.12", | ||
| "canvas-confetti": "^1.9.3", | ||
| "mitt": "^3.0.1", | ||
| "ora": "^9.4.1", |
There was a problem hiding this comment.
since ora is imported from backend seed code, should it be declared in the backend workspace package rather than only in the root package.json not sure just a thought
There was a problem hiding this comment.
i assume its in this one? i just did yarn install and it put it there. might be good to get waverly's thoughts though.
wavehassman
left a comment
wavehassman
left a comment
There was a problem hiding this comment.
I think there should be more templates and work packages at a null stage
| eslint-plugin-cypress: "npm:4.3.0" | ||
| eslint-plugin-prettier: "npm:^5.2.2" | ||
| mitt: "npm:^3.0.1" | ||
| ora: "npm:^9.4.1" |
There was a problem hiding this comment.
yeah this should go in the backend
| } | ||
|
|
||
| console.log(`${instance.constructor.name} complete`); | ||
| const totalElapsed = `${((Date.now() - totalStart) / 1000).toFixed(2)}s`; |
There was a problem hiding this comment.
move this to the catch like
} catch (e) {
const elapsed = `${((Date.now() - start) / 1000).toFixed(2)}s`;
spinner.fail(`${index} ${name} ${elapsed}`);
const totalElapsed = `${((Date.now() - totalStart) / 1000).toFixed(2)}s`;
console.log();
console.log(` ❌ Seed failed on ${instance.constructor.name.trim()} after ${totalElapsed}`);
console.log();
throw e;
}
The failures counter is never hit because it will throw
There was a problem hiding this comment.
looking back at this, I don't love how they're all WP1..2...3... and so forth. they are usually like design, manufacturing, etc. also no work packages are blocked by others, idk if that is a later ticket, but we should definitely have some blockers. there are no upcoming work packages, they are all hella overdue. can we make the deadlines more realistic?
also for the current projects, all work packages are active. only one or two should be active at a time normally, and if something is blocking another thing that can't be activated until the first one is completed
3 participants
Changes
Added factory and process for work package generation on top of projects.
Checklist
yarn.lockchanges (unless dependencies have changed)Closes #4215 (issue #4215)