tesla_preap: make regen under-delivery prompt reachable - #3
Merged
Conversation
Field capture from 2026-07-22 (minutes after supercharging) shows the old gate could never fire: the command sat within 0.5 DI of the rail for only 0.3s of a multi-second under-delivery, and one noisy aEgo sample reset the consecutive dwell counter anyway. Gate on a deep-regen command with a real decel request instead, and accumulate evidence in a saturating counter. Replaying the captured route fires the prompt once at the weak-regen event and stays silent through grade-compensated uphill decels; both windows are committed as fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field capture from 2026-07-22 (minutes after supercharging) shows the old
gate could never fire: the command sat within 0.5 DI of the rail for only
0.3s of a multi-second under-delivery, and one noisy aEgo sample reset the
consecutive dwell counter anyway. Gate on a deep-regen command with a real
decel request instead, and accumulate evidence in a saturating counter.
Replaying the captured route fires the prompt once at the weak-regen event
and stays silent through grade-compensated uphill decels; both windows are
committed as fixtures under
opendbc/car/tesla/preap/tests/data/.