[18.0][MIG] stock account operating unit: Migration to 18.0 - #769
[18.0][MIG] stock account operating unit: Migration to 18.0#769AtaponDew wants to merge 26 commits into
Conversation
|
Hi @AtaponDew the dependency is merged now :) Can you please rebase? |
| def _generate_valuation_lines_data( | ||
| self, | ||
| partner_id, | ||
| qty, | ||
| debit_value, | ||
| credit_value, | ||
| debit_account_id, | ||
| credit_account_id, | ||
| description, | ||
| ): |
There was a problem hiding this comment.
you are missing parameter: svl_id
| def _generate_valuation_lines_data( | |
| self, | |
| partner_id, | |
| qty, | |
| debit_value, | |
| credit_value, | |
| debit_account_id, | |
| credit_account_id, | |
| description, | |
| ): | |
| def _generate_valuation_lines_data( | |
| self, | |
| partner_id, | |
| qty, | |
| debit_value, | |
| credit_value, | |
| debit_account_id, | |
| credit_account_id, | |
| svl_id, | |
| description, | |
| ): |
There was a problem hiding this comment.
Thank you @kongrattapong, I have committed fix of this issue.
Added Test Cases. Improved code for test cases Migrated Valuation method of quants. Migrated Valuation method _account_entry_move of quants. Completed test cases and modified valuation method
Currently translated at 100.0% (3 of 3 strings) Translation: operating-unit-13.0/operating-unit-13.0-stock_account_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-stock_account_operating_unit/es/
FIX test-requirements
…it is not longer required
379c656 to
630d914
Compare
…e_valuation_lines_data
|
@AaronHForgeFlow I've already rebase, please review. Thanks. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
AaronHForgeFlow
removed
the
stale
|
can you squash the migration to 18 commit with the commits after it? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
9 participants
No description provided.