[16.0][FIX] dbfilter_from_header: revert patch breaking security - #3698
Open
hbrunn wants to merge 3 commits into
Open
[16.0][FIX] dbfilter_from_header: revert patch breaking security#3698hbrunn wants to merge 3 commits into
hbrunn wants to merge 3 commits into
Conversation
OCA-git-bot
added
series:16.0
mod:dbfilter_from_header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #2828 we merged a patch that breaks the promise from the readme that the filter from the header goes on top of an existing dbfilter configured in the config file. This can lead to bad surprises, so should be reverted.
Cherry-picked #3696 here for completeness