[19.0][ADD] spreadsheet_dashboard_share_oca: manage dashboard share links - #130
Open
volkantasci wants to merge 2 commits into
Open
[19.0][ADD] spreadsheet_dashboard_share_oca: manage dashboard share links#130volkantasci wants to merge 2 commits into
volkantasci wants to merge 2 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:spreadsheet_dashboard_share_oca
The o_spreadsheet bundle compiler derives a module id from the file path
by stripping only the trailing '.js' extension, so a file named
share_manage_dialog.esm.js is registered under
'.../share_manage_dialog.esm'. The import in share_button_patch
referenced the module without the '.esm' suffix, so the dialog was never
found ('module not defined' in the browser console) and the Manage
shares button never appeared. Import the module with its '.esm' suffix,
matching the pattern used by the other bundle modules of this repo
(e.g. spreadsheet_oca).
volkantasci
force-pushed
the
19.0-add-spreadsheet-dashboard-share-oca
branch
from
August 5, 2026 00:11
c494e67 to
62beb16
Compare
Author
|
Hi @pedrobaeza and @victoralmau 👋 Just a gentle check-in — if anyone has a moment, this PR would really benefit from a look whenever you're available. All CI checks are green (pre-commit, Odoo/OCB tests, codecov, runboat). No pressure at all — happy to make any changes you suggest. Thanks for everything you do! |
Member
|
I think this should be part of the main module, as the share option is something already in it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module adds share-link management to the spreadsheet dashboards
(Rapor Panelleri) of Odoo 19.
Features
share links of the active dashboard with creation date and creator
and collapsed), refreshed live when shares are created or revoked
Dashboards / Admin group (
spreadsheet_dashboard.group_dashboard_manager)can see and revoke shares created by any user
Technical notes
@api.modelmethods onspreadsheet.dashboard.share(
action_get_dashboard_shares,action_unshare,action_get_share_counts)spreadsheet.ShareButtonandspreadsheet_dashboard.DashboardAction(Expanded/Collapsed), new OWLShareManageDialogcomponent; no core file is modifiedtests for the dialog
suite (ruff, prettier, eslint, pylint, oca checks)
Screenshots
(available on request)