Fix terminal emulation in firecracker sessions - #87
Merged
Conversation
Make sure to place the caller terminal in raw mode such that tab completion can work. Additionally make sure to setup window size and terminal type correctly
Contributor
Author
|
Finally I could fix the terminal emulation when calling a pty over a vsock in a firecracker session. This now makes the terminal really usable :) Tested with the claude UI which is an ncurses based UI using many terminal features It still does not cover everything, a few escape sequences VTE(8003) are still unsupported. |
rjschwei
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to place the caller terminal in raw mode such that tab completion can work. Additionally make sure to setup window size and terminal type correctly