Added Infineon_Device_Configurator and InfineonMcuConfigWizard#2528
Added Infineon_Device_Configurator and InfineonMcuConfigWizard#2528OttJulia wants to merge 3 commits into
Conversation
… and LITIX devices) (
There was a problem hiding this comment.
a) There already exists a global generator with ID InfineonDeviceConfigurator. You are adding a global generator ID Infineon_Device_Configurator using _ this can be easily overlooked and can cause user confusion.
The download-url is identical: https://softwaretools.infineon.com/tools/com.ifx.tb.tool.deviceconfigurator
However the run: node and the path: are different.
Is there a good reason why this cannot be unified?
b) The "run:" node specified a *.bat file which only executes on windows, specify a launch script without extension and then provide launch scripts with different launch scripts for each platform
- darwin-arm-64 (bash)
- linux-amd64 (bash)
- linux-arm64 (bash)
- windows-amd64 (bat)
- windows-arm64 (bat)
even if the invocation just prints:Platform is not supported for Infineon Device Configurator!andexit 1.
The generator much not silently fail and leave the user puzzled.
c) The launch scripts need to be added via a PR in this repository:
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts
The existing Infineon script are here:
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts/Infineon_Device_Configurator
d) For the InfineonMcuConfigWizard scripts need to be added via a PR as well:
https://github.com/Open-CMSIS-Pack/generator-bridge/tree/main/scripts/InfineonMcuConfigWizard
|
a) I see where the confusion comes from, especially because InfineonDeviceConfigurator uses a folder named Infineon_Device_Configurator in the bridge repo. b/c/d) Thanks, I will update the run element and add the scripts once the name is clarified |
|
Thanks for sharing the background. |
Test Results 2 files - 37 14 suites - 107 12m 10s ⏱️ - 6m 15s Results for commit ee47f8e. ± Comparison against base commit dac8555. This pull request removes 451 tests. |
removed bat file ending from generator scripts reference
|
@OttJulia, could you please create the PR for the launch scripts you are referencing |
|
Created a PR for the generator files: Open-CMSIS-Pack/generator-bridge#355 |
Added Infineon_Device_Configurator and InfineonMcuConfigWizard (MOTIX and LITIX devices)
Fixes
Changes
Checklist