Skip to content

Ctrace - #2547

Merged
thorstendb-ARM merged 3 commits into
mainfrom
ctrace
Jul 29, 2026
Merged

Ctrace#2547
thorstendb-ARM merged 3 commits into
mainfrom
ctrace

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Changes

  • Initial workflow commit for new tool ctrace

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@grasci-arm grasci-arm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One serious workflow issue: the new ctrace workflow appears incomplete/truncated and may not actually be executable as added. No other patch lines show a clear blocking correctness regression from the supplied diff.

@github-actions

Copy link
Copy Markdown

Test Results

 4 files   8 suites   8s ⏱️
49 tests 49 ✅ 0 💤 0 ❌
98 runs  98 ✅ 0 💤 0 ❌

Results for commit 008b17a.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Test Results

  2 files   14 suites   14m 0s ⏱️
477 tests 477 ✅ 0 💤 0 ❌
954 runs  954 ✅ 0 💤 0 ❌

Results for commit 008b17a.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.32%. Comparing base (2dfa33b) to head (008b17a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2547   +/-   ##
=======================================
  Coverage   68.31%   68.32%           
=======================================
  Files         140      141    +1     
  Lines       26507    26510    +3     
  Branches    16021    16021           
=======================================
+ Hits        18109    18112    +3     
+ Misses       6093     6090    -3     
- Partials     2305     2308    +3     
Flag Coverage Δ
buildmgr-cov 79.87% <ø> (ø)
ctrace-cov 100.00% <100.00%> (?)
packchk-cov 69.75% <ø> (ø)
packgen-cov 82.02% <ø> (ø)
projmgr-cov 88.01% <ø> (ø)
svdconv-cov 46.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/ctrace/src/CtraceMain.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JonatanAntoni

JonatanAntoni commented Jul 29, 2026

Copy link
Copy Markdown
Member

@soumeh01 there are a couple of Node20 deprecation warnings listed. Did we miss to update all the shared actions used in this repo?

@JonatanAntoni JonatanAntoni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much good to me as a starting point. I'll leave it to @soumeh01 to finally approve.

@soumeh01 soumeh01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@thorstendb-ARM
thorstendb-ARM merged commit d7bf540 into main Jul 29, 2026
113 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the ctrace branch July 29, 2026 13:37
@soumeh01

Copy link
Copy Markdown
Contributor

@soumeh01 there are a couple of Node20 deprecation warnings listed. Did we miss to update all the shared actions used in this repo?

We use the recommended FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 matches GitHub's official documentation for the Node 24 opt-in mechanism.
Even after setting FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true, we still see the warning:
The following actions are running on Node.js 20 and may not work as expected: XYZ-action@v1.

There is a known actions/runner#4295 bug where the deprecation warning annotation can still fire even with this variable set, because the runner evaluates the declared node20 version before checking the override. The actions will still run on Node 24 at runtime. The warning text is just misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants