Ctrace - #2547
Conversation
grasci-arm
left a comment
There was a problem hiding this comment.
One serious workflow issue: the new ctrace workflow appears incomplete/truncated and may not actually be executable as added. No other patch lines show a clear blocking correctness regression from the supplied diff.
Test Results 4 files 8 suites 8s ⏱️ Results for commit 008b17a. |
Test Results 2 files 14 suites 14m 0s ⏱️ Results for commit 008b17a. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2547 +/- ##
=======================================
Coverage 68.31% 68.32%
=======================================
Files 140 141 +1
Lines 26507 26510 +3
Branches 16021 16021
=======================================
+ Hits 18109 18112 +3
+ Misses 6093 6090 -3
- Partials 2305 2308 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@soumeh01 there are a couple of Node20 deprecation warnings listed. Did we miss to update all the shared actions used in this repo? |
JonatanAntoni
left a comment
There was a problem hiding this comment.
Looks pretty much good to me as a starting point. I'll leave it to @soumeh01 to finally approve.
We use the recommended FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 matches GitHub's official documentation for the Node 24 opt-in mechanism. There is a known actions/runner#4295 bug where the deprecation warning annotation can still fire even with this variable set, because the runner evaluates the declared node20 version before checking the override. The actions will still run on Node 24 at runtime. The warning text is just misleading. |
Changes
Checklist