DXE Core and Readiness Tool Makefile Updates [Rebase & FF] - #182
Merged
makubacki merged 2 commits intoJul 24, 2026
Conversation
…iles Set `coverage_attribute` only when running coverage. Updates the patina-dxe-core-qemu and patina-readiness-tool makefiles to set the feature in their makefiles similar to other files. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
This task currently fails because it expects a workspace with members. Even if that's accounted for, the repo does not emphasize testing coverage. The task is removed in this change to simplify the file. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Javagedes
approved these changes
Jul 24, 2026
vineelko
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits to bring changes to these repos made elsewhere.
.sync: Constrain
coverage_attributein DXE Core and Readiness makefilesSet
coverage_attributeonly when running coverage. Updates thepatina-dxe-core-qemu and patina-readiness-tool makefiles to set the
feature in their makefiles similar to other files.
Makefile-patina-dxe-core-qemu.toml: Drop the coverage-fail task
This task currently fails because it expects a workspace with members.
Even if that's accounted for, the repo does not emphasize testing
coverage. The task is removed in this change to simplify the file.