fix(e1004): reconfigure panel geometry on deep sleep wakeup - #145
Merged
jonasniesner merged 1 commit intoAug 7, 2026
Merged
Conversation
configureBbepPanelGeometry used to live only inline in initDisplay(), which the deep-sleep wake path (main.cpp) skips entirely to save power and keep the panel image. `bbep` is a plain global (not RTC_DATA_ATTR), so a wake reset zeroes it -- leaving e1004GeometryOk false and bbep.type/native_width/native_height unset for the whole boot. On E1004 that makes every e1004_begin_plane() call after wake fail its geometry guard (logged as "E1004 dual-CS plane open failed") and silently drop the panel payload (directWriteSinkBytes only forwards bytes when e1004GeometryOk), which is what produces static on the left half and a stale right half. Calling this from epdSessionAcquire()'s cold bring-up as well as initDisplay() ensures the type/geometry state exists before any panel command sequence runs, whether this is a fresh cold boot or the first push after waking.
Member
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fix
Summary
configureBbepPanelGeometry used to live only inline in initDisplay(), which the deep-sleep wake path (main.cpp) skips entirely to save power and keep the panel image.
bbepis a plain global (not RTC_DATA_ATTR), so a wake reset zeroes it -- leaving e1004GeometryOk false and bbep.type/native_width/native_height unset for the whole boot. On E1004 that makes every e1004_begin_plane() call after wake fail its geometry guard (logged as "E1004 dual-CS plane open failed") and silently drop the panel payload (directWriteSinkBytes only forwards bytes when e1004GeometryOk), which is what produces static on the left half and a stale right half. Calling this from epdSessionAcquire()'s cold bring-up as well as initDisplay() ensures the type/geometry state exists before any panel command sequence runs, whether this is a fresh cold boot or the first push after waking.