fix(boot): fill the boot-screen swatches on BWR/BWY panels - #149
Merged
Conversation
The footer swatches advertise the colors a panel can produce, but on a bitplane scheme the black one rendered as an empty outlined box. The interior fill was skipped for BWR/BWY by an `!useBitplanes` guard. The guard is unnecessary: swatch codes reach setBootPixelCode(), which at 1 bpp already clears the bit for code 0 and sets it for code 1 — exactly the black and white the B/W plane needs. The colored swatch never reaches this path at all; colorPlanePass paints it on PLANE_1 and continues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
The boot screen's footer swatches skipped their interior fill on B/W/R and
B/W/Y configs, so the black swatch rendered as an empty outlined box.
The fill was gated behind
!useBitplanes. The guard is unnecessary: swatchcodes go through
setBootPixelCode(), which at 1 bpp already clears the bitfor code 0 and sets it for code 1 — exactly the black and white the B/W
plane needs. The coloured swatch never reaches this path at all;
colorPlanePasspaints it onPLANE_1and continues.Verified on P750057-MF1-A 7.5" B/W/R panel