fix(ksp-codegen): recognize @QuerySupertype and @QueryEmbeddable in autodetect#1858
Open
kylequera wants to merge 1 commit into
Open
fix(ksp-codegen): recognize @QuerySupertype and @QueryEmbeddable in autodetect#1858kylequera wants to merge 1 commit into
kylequera wants to merge 1 commit into
Conversation
…utodetect QueryModelType.autodetect() only matched jakarta annotations for SUPERCLASS and EMBEDDABLE models. A @QueryEntity class whose superclass is @QuerySupertype failed with "Unable to resolve type of entity" during KSP codegen. Fixes OpenFeign#1857 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryModelType.autodetect()to recognize querydsl's own@QuerySupertypeand@QueryEmbeddableannotations, matching the jakarta@MappedSuperclass/@Embeddablehandling already present for KSP codegen.@QueryEntityclass extending a@QuerySupertypebase fails during KSP processing withUnable to resolve type of entity for <superclass fqn>and no Q classes are generated.Fixes #1857
Test plan
./mvnw -Dtoolchain.skip=true -Pdev -pl querydsl-tooling/querydsl-ksp-codegen test -Dtest=KspProcessorIntegrationTest,RenderTest(25 tests, all green locally on JDK 21)./mvnw -Pdev verifyMade with Cursor