Lint: fix credo error#4964
Open
josephjclark wants to merge 4 commits into
Open
Conversation
Security Review ✅
|
elias-ba
approved these changes
Jul 12, 2026
elias-ba
left a comment
Contributor
There was a problem hiding this comment.
Pushed a small alternative @josephjclark: folded the two rejects into one pass with or so credo passes for real, rather than suppressing it.
Contributor
|
Hey @josephjclark, I pushed another commit directly here to fix a flaky JS test that was failing CI on this PR. Nothing to do with your change, just a pre-existing test in |
Collaborator
Author
|
@elias-ba that commit should have been a different PR really! Let me check and merge. |
josephjclark
commented
Jul 13, 2026
| target_workflows | ||
| |> Enum.reject(fn wf -> MapSet.member?(source_workflow_names, wf.name) end) | ||
| |> Enum.reject(fn wf -> workflow_added_after_fork?(wf, source) end) | ||
| |> Enum.reject(fn wf -> |
Collaborator
Author
There was a problem hiding this comment.
Is this change expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our lint tests are failing for a bunch of reasons, but one of them is this credo error:
Looking at the code in question I'm not too worried about performance, I think the code is clearer using two iterations.
Claude says this:
On that basis I've disabled credo for that line. Open to suggestions but I think this is quite reasonable.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy