Skip to content

fix: exit cleanly on failed login in oiecommand #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dowel015 wants to merge 1 commit into from
Closed

fix: exit cleanly on failed login in oiecommand #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions command/src/com/mirth/connect/cli/CommandLineInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import com.mirth.connect.client.core.BrandingConstants;
import com.mirth.connect.client.core.Client;
import com.mirth.connect.client.core.ClientException;
import com.mirth.connect.client.core.UnauthorizedException;
import com.mirth.connect.client.core.ListHandlerException;
import com.mirth.connect.client.core.PaginatedEventList;
import com.mirth.connect.client.core.PaginatedMessageList;
Expand Down Expand Up @@ -216,14 +217,19 @@ private void runShell(String server, String user, String password, String script
runConsole();
}
client.logout();
client.close();
out.println("Disconnected from server.");
} catch (UnauthorizedException ue) {
error("Could not login to server: invalid username or password.", null);
} catch (ClientException ce) {
ce.printStackTrace();
error("A client error occurred.", ce);
} catch (IOException ioe) {
error("Could not load script file.", ioe);
} catch (URISyntaxException e) {
error("Invalid server address.", e);
} finally {
if (client != null) {
client.close();
}
Comment on lines +229 to +232

@kpalang kpalang Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Since Client implements AutoCloseable I would replace the finally clock with a try-with-resources approach.

try (var client = new Client(server)) {

}
}

Expand Down