Security: fix RTMP auth rate limit bypass before on_connect#59
Closed
cursor[bot] wants to merge 3 commits into
Closed
Security: fix RTMP auth rate limit bypass before on_connect#59cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Register client remote_addr inside publish/play callbacks during poll() so per-IP auth failure tracking applies before the first publish/play attempt. Adds regression tests for the pre-on_connect race. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR #59 added clear_rtmp_poll_server and set_rtmp_poll_server imports that rustfmt wants on two lines instead of three. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RTMP auth rate limit bypass before on_connect. Resolves publish/play callbacks firing inside poll() before client IP registration, which skipped per-IP auth failure tracking (10 failures/60s). Registers remote_addr from the active Server during callbacks via thread-local poll context.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.