Skip to content

Parallelism2#10

Open
timmens wants to merge 1 commit into
parallelismfrom
parallelism2
Open

Parallelism2#10
timmens wants to merge 1 commit into
parallelismfrom
parallelism2

Conversation

@timmens

@timmens timmens commented Jan 19, 2024

Copy link
Copy Markdown
Member

What we did:

  • Differentiate between search radius factor and sample radius factor in speculative sampling

What happened:

  • Benchmark results got slightly worse (especially for 4 and 8 cores)

What we want to do:

General idea: Make speculative sampling resemble sampling step after acceptance decision

  • Tune search radius factor for parallel optimizer
  • Use filter on existing points in speculative sampling

@timmens
timmens changed the base branch from main to parallelism January 19, 2024 17:57
@codecov

codecov Bot commented Jan 19, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.47%. Comparing base (1cacab1) to head (ee26d56).
⚠️ Report is 1 commits behind head on parallelism.

Additional details and impacted files
@@             Coverage Diff              @@
##           parallelism      #10   +/-   ##
============================================
  Coverage        78.46%   78.47%           
============================================
  Files               68       68           
  Lines             4928     4929    +1     
============================================
+ Hits              3867     3868    +1     
  Misses            1061     1061           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant