Skip to content

test: POSIX-normalise paths in link_priority_structural_test (fixes 4 Windows-only failures) #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulsaheel merged 1 commit into from
Aug 15, 2026
Merged

test: POSIX-normalise paths in link_priority_structural_test (fixes 4 Windows-only failures) #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion test/link_priority_structural_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,20 @@ List<MapEntry<String, List<String>>> _libSources() {
final out = <MapEntry<String, List<String>>>[];
for (final entity in lib.listSync(recursive: true)) {
if (entity is! File || !entity.path.endsWith('.dart')) continue;
out.add(MapEntry(entity.path, codeLines(entity.readAsStringSync())));
// POSIX-normalise. Directory.listSync returns NATIVE separators, so on
// Windows every key here is `lib\ble\ble_engine.dart` while every assertion
// below is written `lib/ble/ble_engine.dart`. Nothing about what this file
// pins is platform-specific, so the paths it reasons about should not be
// either — normalising once here keeps the assertions readable as the
// single spelling they already use.
//
// Replacing Platform.pathSeparator rather than a literal backslash: on
// POSIX that is a no-op, whereas a blanket `\` replacement would corrupt
// the (legal, if perverse) filename that contains one.
out.add(MapEntry(
entity.path.replaceAll(Platform.pathSeparator, '/'),
codeLines(entity.readAsStringSync()),
));
}
out.sort((a, b) => a.key.compareTo(b.key));
return out;
Expand Down
Loading