4.6.2

[MakinoharaShoko]

No description provided.

[cloudflare-workers-and-pages]

Deploying webgal-dev with    Cloudflare Pages

Latest commit:	6b4cbf6
Status:	✅  Deploy successful!
Preview URL:	https://6e4b44bd.webgal-dev.pages.dev

View logs

[gemini-code-assist]

Code Review

This pull request introduces a flowchart feature to WebGAL, allowing players to track and jump to unlocked story nodes, and enhances the editor's live preview stability and protocol. It also refactors sentence advancement and fixes bugs in video playback, backlog audio, and comment parsing. The review feedback identifies several critical robustness issues, including potential runtime TypeErrors from unsafe property access on currentScene and node.data, unsafe string trimming in the transform parser, and an unconditional state commit when a forward step is blocked. Additionally, it suggests replacing the non-standard 'chinese' locale with 'zh-CN' for consistent time formatting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The functions parseTransformFrame and parseSetTransformFrame assume that the raw parameter is always a valid string. If raw is null, undefined, or of a non-string type, calling raw.trim() will throw a runtime TypeError. Adding a type guard to ensure raw is a string before trimming makes the parsing robust against unexpected inputs.

export function parseTransformFrame(raw: string | null | undefined): AnimationFrame | null {
  if (typeof raw !== 'string') return null;
  const source = raw.trim();
  if (source === '') return null;

  try {
    const parsed: unknown = JSON.parse(source);
    return isTransformFrame(parsed) ? parsed : null;
  } catch {
    return null;
  }
}

export function parseSetTransformFrame(raw: string | null | undefined): AnimationFrame | null {
  if (typeof raw !== 'string') return null;
  return parseTransformFrame(raw.trim() === '' ? '{}' : raw);
}

[gemini-code-assist]

In continueSentence, commitForward() is called unconditionally after forward(). However, forward() can return false if the forward step is blocked by a scene write lock (WebGAL.sceneManager.lockSceneWrite). If forward() fails, calling commitForward() will commit an invalid or stale state, potentially leading to state desynchronization. Only call commitForward() if forward() returns true.

  if (forward()) {
    commitForward();
  }

[gemini-code-assist]

In unlockCurrentScene, this.sceneManager.sceneData.currentScene is accessed directly. During initialization or scene transitions, sceneData or currentScene might be undefined or null, which would cause a runtime crash. Adding a defensive check prevents potential TypeErrors.

  public unlockCurrentScene(refreshSnapshot = false) {
    if (!this.hasFlowchart()) return;
    const currentScene = this.sceneManager.sceneData?.currentScene;
    if (!currentScene) return;
    const sceneNames = new Set([
      normalizeSceneName(currentScene.sceneName),
      normalizeSceneName(currentScene.sceneUrl),
    ]);

[gemini-code-assist]

In createSnapshot, this.sceneManager.sceneData.currentScene is accessed directly, which can throw a TypeError if it is null or undefined. Additionally, 'chinese' is not a standard BCP 47 language tag for toLocaleTimeString and may cause inconsistent formatting or errors across different browser environments. It is safer to use 'zh-CN' and add optional chaining/nullish coalescing fallback values.

Suggested change

	private createSnapshot(): ISaveData {
	return {
	nowStageState: cloneDeep(stageStateManager.getViewStageState()),
	backlog: [],
	index: -1,
	saveTime: new Date().toLocaleDateString() + ' ' + new Date().toLocaleTimeString('chinese', { hour12: false }),
	sceneData: {
	currentSentenceId: this.sceneManager.sceneData.currentSentenceId,
	sceneStack: cloneDeep(this.sceneManager.sceneData.sceneStack),
	sceneName: this.sceneManager.sceneData.currentScene.sceneName,
	sceneUrl: this.sceneManager.sceneData.currentScene.sceneUrl,
	},
	previewImage: '',
	};
	}
	private createSnapshot(): ISaveData {
	const currentScene = this.sceneManager.sceneData?.currentScene;
	return {
	nowStageState: cloneDeep(stageStateManager.getViewStageState()),
	backlog: [],
	index: -1,
	saveTime: new Date().toLocaleDateString('zh-CN') + ' ' + new Date().toLocaleTimeString('zh-CN', { hour12: false }),
	sceneData: {
	currentSentenceId: this.sceneManager.sceneData?.currentSentenceId ?? 0,
	sceneStack: cloneDeep(this.sceneManager.sceneData?.sceneStack ?? []),
	sceneName: currentScene?.sceneName ?? '',
	sceneUrl: currentScene?.sceneUrl ?? '',
	},
	previewImage: '',
	};
	}

[gemini-code-assist]

In currentSceneKey, destructuring currentScene from this.sceneManager.sceneData will throw a runtime error if sceneData or currentScene is null/undefined. Adding optional chaining and a fallback ensures safety.

  private currentSceneKey() {
    const currentScene = this.sceneManager.sceneData?.currentScene;
    if (!currentScene) return '';
    return normalizeSceneName(currentScene.sceneName) + '|' + normalizeSceneName(currentScene.sceneUrl);
  }

[gemini-code-assist]

In getNodeWidth, node.data?.label or node.id is passed directly to Array.from(). If either of these properties is not a string (e.g., a number or boolean from the JSON configuration), Array.from() will throw a runtime TypeError. Explicitly casting the label to a string first prevents this issue.

Suggested change

	function getNodeWidth(node: IFlowchartNode, flowchartId: string, lockedNodeVisibility: LockedNodeVisibility) {
	if (lockedNodeVisibility === 'node' && !WebGAL.flowchartManager.isUnlocked(flowchartId, node.id))
	return NODE_MIN_WIDTH;
	const label = node.data?.label || node.id;
	const textWidth = Array.from(label).reduce((sum, char) => sum + (char.charCodeAt(0) > 255 ? 24 : 14), 0);
	return Math.max(NODE_MIN_WIDTH, textWidth + 36);
	}
	function getNodeWidth(node: IFlowchartNode, flowchartId: string, lockedNodeVisibility: LockedNodeVisibility) {
	if (lockedNodeVisibility === 'node' && !WebGAL.flowchartManager.isUnlocked(flowchartId, node.id))
	return NODE_MIN_WIDTH;
	const label = String(node.data?.label ?? node.id);
	const textWidth = Array.from(label).reduce((sum, char) => sum + (char.charCodeAt(0) > 255 ? 24 : 14), 0);
	return Math.max(NODE_MIN_WIDTH, textWidth + 36);
	}