Add Kubernetes integration create/update with ETL definitions#628
Open
saditya370 wants to merge 1 commit into
Open
Add Kubernetes integration create/update with ETL definitions#628saditya370 wants to merge 1 commit into
saditya370 wants to merge 1 commit into
Conversation
Adds CreateIntegrationKubernetes / UpdateIntegrationKubernetes, KubernetesIntegrationInput, and a KubernetesIntegration fragment exposing extractDefinition and transformDefinition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Go client support for managing a Kubernetes infra integration's ETL config
(extract/transform definitions) via the public GraphQL API. Customer ask from
GitLab issue #14148 (Truelayer wants to manage their Kubernetes integration ETL
as code). The schema side is already merged in the monolith (MR !19177); this is
the client counterpart.
Changes
KubernetesIntegrationInput(name,extractDefinition,transformDefinitionas
*Nullable[string]) — hand-written alongsideAWSIntegrationInputsinceinput.gois generated.CreateIntegrationKubernetes(input)→kubernetesIntegrationCreateUpdateIntegrationKubernetes(identifier, input)→kubernetesIntegrationUpdateKubernetesIntegrationFragment(ExtractDefinition,TransformDefinition) added to theIntegrationstruct as... on KubernetesIntegration, with the sharedintegration_requesttesttemplate updated in the matching position so existing recorded queries still match.
TestCreateKubernetesIntegration/TestUpdateKubernetesIntegrationassert the ETL definitions round-trip through the mutations.
.changes/unreleased/.Mutation/input/field names verified against the monolith's committed public
schema dump (
public/schemas/schema.graphql).Testing
go build ./...go test -race ./...— full suite passes (existing integration tests double asa regression check for the shared query-template change)
task lint(gofumpt + golangci-lint) — 0 issues