Skip to content

chore: update references from @talos/client to @oplabs/talos-client, …#2946

Merged
sparrowDom merged 12 commits into
masterfrom
chore/use-talos-package
Jul 22, 2026
Merged

chore: update references from @talos/client to @oplabs/talos-client, …#2946
sparrowDom merged 12 commits into
masterfrom
chore/use-talos-package

Conversation

@toniocodo

@toniocodo toniocodo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What

Migrates the origin-dollar runner off git-installing @talos/client from the private oplabs/talos repo (SSH deploy key) to the published @oplabs/talos-client GitHub Package. Companion to oplabs/talos#19 (which publishes it) and OriginProtocol/arm-oeth#305.

Changes

  • @talos/client@oplabs/talos-client, declared as an optional peer dependency; the runner Dockerfile installs the pinned version with a read:packages PAT (TALOS_PACKAGE_TOKEN secret). No more SSH deploy key / git install.
  • autoInstallPeers: false (pnpm-workspace.yaml + lockfile) so pnpm never tries to resolve the optional peer without a token — token-less pnpm install passes locally, in CI, and in the Docker build.
  • Lazy require of the client in contracts/utils/signers.js, behind the DATABASE_URL gate, so hardhat boots when the optional package is absent.
  • Dockerfile: # syntax=docker/dockerfile:1.10 (for the env= secret mount) + pnpm add --save-prod.
  • @lodestar ^1.41.0 → ^1.44.0 (the one non-obvious change — worth a look): 1.44 drops @lodestar/config's spurious @lodestar/spec-test-util dependency, which shipped a broken vitest: "catalog:" that broke any workspace re-resolution (i.e. the runner image's pnpm add). Net lockfile shrink (~600 lines); retired the now-dead spec-test-util packageExtension.
  • Pin @oplabs/talos-client@0.0.28; remove an accidental root pnpm-workspace.yaml / pnpm-lock.yaml.

Validation

  • defi.yml green. The failing Base Fork Tests job is pre-existing and non-blocking — it fails on master too and is unrelated to @lodestar (Base is L2, no consensus-layer usage).
  • Runner image builds locally end-to-end (frozen install + token-authed pnpm add @oplabs/talos-client@0.0.28).

TALOS_PACKAGE_TOKEN (a read:packages PAT) must stay set on the repo. The image build runs on master; the actual runner roll is a separate signed release.

…add .npmrc for GitHub package registry configuration WIP 🚧
@toniocodo toniocodo self-assigned this Jul 21, 2026
toniocodo and others added 6 commits July 21, 2026 09:11
…stall

- contracts/pnpm-workspace.yaml: autoInstallPeers false + exclude
  @oplabs/talos-client from the release-age gate (matches arm-oeth)
- remove accidental root pnpm-workspace.yaml + pnpm-lock.yaml
The real fix for the red install — the deletions-only commit before this
missed the file. autoInstallPeers false makes pnpm skip the optional
@oplabs/talos-client peer (no 404 without a token); matches arm-oeth.
Matches contracts/pnpm-workspace.yaml so frozen-lockfile installs (CI +
Docker) don't hit ERR_PNPM_LOCKFILE_CONFIG_MISMATCH. Settings-only change;
a full regen is blocked by an unrelated pre-existing vitest catalog ref.
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (07a7fcb) to head (0ce0e3b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
- Coverage   47.33%   46.05%   -1.29%     
==========================================
  Files         110      110              
  Lines        4920     4920              
  Branches     1362     1362              
==========================================
- Hits         2329     2266      -63     
- Misses       2587     2650      +63     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sparrowDom
sparrowDom marked this pull request as ready for review July 21, 2026 17:16
toniocodo and others added 4 commits July 22, 2026 09:55
- # syntax=docker/dockerfile:1.10 so the env= secret mount is supported
- pnpm add --save-prod (pnpm rejects the no-save option on add)
…ension

1.44 drops @lodestar/config's spurious @lodestar/spec-test-util dependency,
which shipped a broken 'vitest: catalog:' that broke any workspace
re-resolution (e.g. the runner image's pnpm add step). Also removes the now
-dead spec-test-util packageExtension; lockfile shrinks ~600 lines.

@sparrowDom sparrowDom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparrowDom
sparrowDom merged commit 45d8b88 into master Jul 22, 2026
15 of 16 checks passed
@sparrowDom
sparrowDom deleted the chore/use-talos-package branch July 22, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants