Skip to content

ROU-12905: fix DatePicker onChange not firing on manual -1 day entry #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gnbm wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Draft

ROU-12905: fix DatePicker onChange not firing on manual -1 day entry #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,9 +1776,19 @@ function FlatpickrInstance(

if (self.config.altInput) {
const hiddenInputValue = self.element.getAttribute("value") as string;
// Parse the hidden value with flatpickr's own parser (local time) rather
// than new Date(), whose date-only ("Y-m-d") parsing is treated as UTC and
// therefore shifts to the previous day under negative timezone offsets,
// making a one-day-earlier manual entry look unchanged and suppressing
// onChange. undefined => no valid baseline => treat the value as changed.
const parsedHiddenDate = self.parseDate(
hiddenInputValue,
self.config.dateFormat
);
valueChanged =
parsedHiddenDate === undefined ||
self._input.value.trimEnd() !==
self.formatDate(new Date(hiddenInputValue), self.config.altFormat);
self.formatDate(parsedHiddenDate, self.config.altFormat);
}

if (
Expand Down