[BUG] Fix typing_extensions 4.16.0 Sentinel repr break in lowest-direct CI leg#563
Merged
Victor Schappert (vcschapp) merged 1 commit intoJul 15, 2026
Merged
Conversation
typing-extensions 4.16.0 (2026-07-02) changed the repr of its Sentinel from <MISSING> to MISSING. pydantic's experimental MISSING sentinel delegates its repr to typing_extensions.Sentinel, so the Feature doctest in overture-schema-system -- which pins the rendered repr -- breaks against 4.16.0. The default CI legs install from uv.lock (pinned to 4.15.0) and pass; the lowest-direct leg re-resolves transitives to latest, picks up 4.16.0, and fails on every branch and PR, independent of the change under test. - Update the doctest expectation to the current repr (MISSING). - Re-lock typing-extensions to 4.16.0 so the default legs agree. - Floor typing-extensions>=4.16 as a direct dependency of overture-schema-system. The sentinel repr is load-bearing for its doctest, so flooring it makes the lowest-direct resolution deterministic at 4.16.0 rather than floating to whatever transitive is newest. Closes #554. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Victor Schappert (vcschapp)
approved these changes
Jul 15, 2026
Roel Bollens (RoelBollens-TomTom)
self-requested a review
July 15, 2026 16:22
Roel Bollens (RoelBollens-TomTom)
approved these changes
Jul 15, 2026
Victor Schappert (vcschapp)
deleted the
fix-typing-extensions-sentinel-repr
branch
July 15, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #554.
typing-extensions 4.16.0 (2026-07-02) changed the repr of its
Sentinelfrom<MISSING>toMISSING. pydantic's experimentalMISSINGsentinel delegates its repr totyping_extensions.Sentinel, so theFeaturedoctest inoverture-schema-system— which pins the rendered repr — breaks against 4.16.0.The default CI legs install from
uv.lock(pinned to 4.15.0) and pass; thelowest-directleg re-resolves transitives to latest, picks up 4.16.0, and fails on every branch and PR, independent of the change under test.Fix
MISSING).typing-extensionsto 4.16.0 so the default legs agree.typing-extensions>=4.16as a direct dependency ofoverture-schema-system. The sentinel repr is load-bearing for its doctest, so flooring it makes thelowest-directresolution deterministic at 4.16.0 rather than floating to whatever transitive is newest.Verified locally: the doctest passes under both the committed lock (4.16.0) and a
lowest-directre-resolution (which now floorstyping-extensionsto 4.16.0). Independent of #551 — lands cleanly before it; once merged, #551 needs a rebase ontomainto turn itslowest-directleg green.