Revert "Build(deps): bump org.beryx.jlink from 4.0.2 to 4.1.0" - #7677
Merged
karianna merged 1 commit intoJul 24, 2026
Merged
Conversation
This reverts commit 56da102.
🚧 PCGen Code Coverage
|
Vest
added a commit
to Vest/pcgen
that referenced
this pull request
Jul 30, 2026
jlink 4.1.0 added a blanket doNotTrackState to its jpackage tasks, so Gradle stopped tracking the app-image output dir. PCGen's assembleJpackageImage/patchMacJpackage copy into that dir, and Gradle's stale-output cleanup then deleted jpackage's .jpackage.xml marker, breaking the :jpackage step. This only surfaced in the nightly (regular CI does not run jpackage), so the bump was merged and reverted twice (PCGen#7670/PCGen#7672, PCGen#7674/PCGen#7677). 4.1.1-rc fixes it upstream (beryx/badass-jlink-plugin@0d4bf7ec): it removes the doNotTrackState and marks the image/installer output dirs @optional, restoring the output tracking that 4.0.2 had. No PCGen-side workaround is needed. Verified locally on macOS/JDK 25: clean fullJpackage succeeds, the .jpackage.xml marker survives, the bundle stays validly signed, and the dmg is produced.
Vest
added a commit
that referenced
this pull request
Jul 30, 2026
jlink 4.1.0 added a blanket doNotTrackState to its jpackage tasks, so Gradle stopped tracking the app-image output dir. PCGen's assembleJpackageImage/patchMacJpackage copy into that dir, and Gradle's stale-output cleanup then deleted jpackage's .jpackage.xml marker, breaking the :jpackage step. This only surfaced in the nightly (regular CI does not run jpackage), so the bump was merged and reverted twice (#7670/#7672, #7674/#7677). 4.1.1-rc fixes it upstream (beryx/badass-jlink-plugin@0d4bf7ec): it removes the doNotTrackState and marks the image/installer output dirs @optional, restoring the output tracking that 4.0.2 had. No PCGen-side workaround is needed. Verified locally on macOS/JDK 25: clean fullJpackage succeeds, the .jpackage.xml marker survives, the bundle stays validly signed, and the dmg is produced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7674