perf: remove coordinator result lock contention#335
Open
qartik wants to merge 1 commit into
Open
Conversation
Collect per-worker results and stats via rayon map/collect, avoiding the shared results mutex and final sort in ParallelCoordinator::run. This keeps deterministic worker ordering while removing a serialization point from the hot parallel path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Arc<Mutex<Vec<_>>>result collector and final global sort fromParallelCoordinator::run()Why this change
The previous implementation forced every worker to contend on one mutex while pushing results, then paid an extra global sort to restore deterministic ordering. This refactor keeps the ordering guarantee while removing both sources of overhead from the hot parallel coordinator path.
Validation
cargo test -p pecos-neo coordinator --quietcargo test -p pecos-neo --quietPerformance metrics (before/after)
Benchmark command:
cargo bench -p benchmarks --bench benchmarks -- 'ParallelCoordinator/'Before =
origin/dev(602ebd0)After = PR head (
f300415)Criterion reported "Performance has improved." for all three shot sizes in the after run.